Use inline elements (instead of LIs and DIVs)

Anybody - March 24, 2009 - 19:16
Project:Views Cloud
Version:6.x-1.0
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

In my oppinion it would be cleaner to use span - tags instead of divs... perhaps you could set this as option, if you don't want to make a hard change.

Span is just better in this case by design (see HTML-Documentation -> correct usage of inline/block-Elements).

Think it wouldn't be hard to add an option to let the user decide.

Thanks!

#1

quicksketch - November 18, 2009 - 02:07
Status:needs work» fixed

Generally I like spans better too, I'd prefer not to burden the administrator with options that have absolutely no effect on the site. I've converted them to spans, since I think 95% use-case these are going to contain plain text (single) strings in each item.

I also didn't find that it made much sense that we used LIs when doing summary views, but then used DIVs when doing the field lists. For the sake of consistency I've made the summary style use SPANs also, so now our markup matches no matter which approach you use.

AttachmentSize
views_cloud_spans.patch 2.44 KB

#2

quicksketch - November 18, 2009 - 02:08
Title:Use inline elements» Use inline elements (instead of LIs and DIVs)

#3

System Message - December 2, 2009 - 02:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.