Download & Extend
Image FUpload » Issues

Provide Compatibility With New ImageField 3.x (RC versions)

Posted by quicksketch on March 24, 2009 at 8:52pm
Project:Image FUpload
Version:6.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

All the custom hooks provided by FileField were removed in the beta1 version, so hooks like "hook_widget_widget_settings_save" no longer exist. These hooks were removed because they added unnecessary complexity and APIs when they weren't really needed, since CCK and FAPI provided all the needed hooks already. It also had the benefit of significantly reducing the code (and bugs) in ImageField. See #397578: Uncouple ImageField from FileField Custom Hooks for the full thread.

However, this also had the side-effect of breaking all the modules that provided extra widgets to FileField, such as Image FUpload. Here's a patch that removes all the custom FileField hooks from Image FUpload ImageField module and makes it compatible with the beta versions of ImageField.

The widget configuration and upload on the node form all works, but I don't quite understand how Image FUpload saves its values and I haven't been able to get that working. Regardless, this is a pretty good start on providing compatibility with the new version of FileField and ImageField. I apologize for all the extra work this has caused and the APIs in ImageField won't change again before the final versions (which I'm hoping to get out within the next 2 weeks).

AttachmentSize
image_fupload_imagefield_new.patch6.2 KB
Login or register to post comments

Comments

#1

Posted by quicksketch on March 24, 2009 at 9:23pm

Also important, you'll need to use the development version (HEAD) of ImageField with this patch. I've re-added the imagefield_widget_upload_validators() function since I now see the value in having it separate from imagefield_widget(). See #402876: Restore imagefield_widget_upload_validators.

#2

Posted by grandcat on March 25, 2009 at 2:24pm

Thank you very much for your patch provided. It really helps a lot, I will do the rest concerning saving some extra values.

#3

Posted by quicksketch on March 25, 2009 at 5:47pm

No problem, with targeting for a stable version of ImageField in the next 2 weeks I don't want users to have additional reason not to upgrade.

Turns out this version does actually save values. I had some invalid formatters setup so the uploaded files weren't displaying. The only apparent piece that was missing for me is that the Image FUpload field doesn't show files I've already uploaded when editing the node.

#4

Posted by grandcat on March 25, 2009 at 7:08pm

Ok. All in all, thank you. Nevertheless, I will do some testings first.

The only apparent piece that was missing for me is that the Image FUpload field doesn't show files I've already uploaded when editing the node.

This is ImageField/Filefield for, it should also display a list of images when editing a created node.

#5

Posted by Flying Drupalist on March 30, 2009 at 4:12am

Subscribe

#6

Posted by Heilong on March 31, 2009 at 6:25am

Subscribe...

#7

Posted by scroogie on March 31, 2009 at 9:32am

subscribe

#8

Posted by gjk on April 3, 2009 at 1:50am

Subscribing.

#9

Posted by grandcat on April 5, 2009 at 8:31pm
Status:needs work» fixed

Thanks to quicksketch. Patch now applied to CVS Head.

#10

Posted by grandcat on April 6, 2009 at 12:13am
Title:Provide Compatibility With New ImageField 3.x (beta versions)» Provide Compatibility With New ImageField 3.x (RC versions)

#11

Posted by System Message on April 20, 2009 at 12:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.