Apostrophes in node titles break parent entries selection

Replicated.

& and most likely any special html entities will likely break clipper.

A better approach would be to find 'nid' that corresponds to the matched 'title' with autocomplete, but insert the 'nid' into the form as value. Then at node_api update/insert it would save the 'nid' value, which would not cause any trouble.

keve, I like your idea, can you provide a patch?

I have not done the new approach, but made some bugfixes.

I removed check_plain() for parent titles, i think node_load is protected against sql injection.

I also removed trim() since in Drupal node title can begin and end with whitespaces.

I am a bit confused: shouldnt the regexp in clipper_autocomplete already grep out charachters?

I fail to see (but then again, I am no regexp guru) why all that pattern replacing on _insert is required.

So, please explain a bit more in detail what the problem is and what the solution provided does. I cannot oversee the curernt solution, and what it tries to do.

Bèr

At autocomplete, If title has " or , in it, autocomplete puts title inside "". It also replaces " with "" in the title.

Eg:
foo "bar" => "foo ""bar"""

Consequently at _insert and _validate i need to remove those " apostrophes to get original title back. with:

      if (preg_match('/".+"/', $parent)) {
        $parent      = trim($parent, '"');
        $parent = preg_replace('/""/', '"', $parent);
      }

Thanks for the patch, keep up the good work...!

Bug for my patch: html special chars breaks autocomplete:

But when i try to insert 2nd entry with autocomplete (and 1st entry has any htmlspecial char in it # of &), it does not suggest any node title.

_insert, _validate works all right w/ them.

On review, the bugs that he's talking about actually keep it from giving suggestions... the childof works but it breaks the autocomplete. I am looking at this right now, will update in a bit. I would not suggest committing this before it's bugfree.

Thanks a lot keve. Committed.

I committed your confirmation message separate. please try to not add in features when fixing a bug. :)

On my screen i am not getting suggestions with that patch... the childof functionality works, but the suggestions don't... Ber or Keve can you confirm this?

I guess it's better committed than not, even if autocomplete is not functioning with htmlspecialentity titles.

We need to figure out that latest issue. RE-opening

what if the node id was appended to the title, node->clipper_parent... so "title [nid]" and the nid was actually used when inserting into node relations...? that sounds doable... any thoughts? i think if this module is to be any real use it must be able to attach properly to different nodes with the same name, right now it will append it to the first node with the name, just tested that...

please do not hijack this issue for other issues. The 'more then one node with the same title' bug is dealt with elsewhere.

sorry about that.

Autocomplete works for me even with 'childof'.
Only if title of child includes htmlspecial char, it breaks autocomplete.

moving to a new issue. it is not really related.