For some reason we changed the way we output error messages. It seems to me that Drupal 6's way was the correct one and the new one is changed for some reason? If there is already an issue for this, please link - but it seems to have slipped through.

The Drupal 6 one:

The Drupal 7 one:

CommentFileSizeAuthor
#14 errorMessage.png42.07 KBaspilicious
dberror.png105.54 KBBojhan
drupal6error.png13.19 KBBojhan

Comments

catch’s picture

Note that if you put any kind of typo for database credentials when you try to install Drupal, that huge wall of red text is what you see.

Bojhan’s picture

Issue tags: +Usability

Tagging

wretched sinner - saved by grace’s picture

I think this is due to D7 being in development, and so all errors are displayed, rather than a reduced set. Are you comparing the install errors with D6 -dev or D6.10?

catch’s picture

These errors are from install.inc with drupal_set_message() etc., not down to error level settings.

webchick’s picture

Category: task » bug
Priority: Normal » Critical

Correct. This has something to do with DBTNG and lack of error trapping.

Subscribing and promoting to a critical bug. We are not releasing with it like this.

catch’s picture

All the messages are defined in:

Abstract class DatabaseInstaller

it's mainly runTestQuery() testConnect() and the $tests array.

I think we'd do fine just showing the message from testConnect() (which looks like the old D6 one) - not sure why runTestQuery() has to do a drupal_set_message() for every fail all at once.

birdmanx35’s picture

Title: Installing Drupal 7 error handeling is diffrent from d6 » Installing Drupal 7 error handling is diffrent from D6
birdmanx35’s picture

Title: Installing Drupal 7 error handling is diffrent from D6 » Installing Drupal 7 error handling is different from D6
tixilite’s picture

We have to get rid of this huge red wall of text. I don't think all the details about which table couldn't be inserted, updated or whatever should be included. It should be more like:

Drupal was unable to insert, update, delete, etc. in the MySQL database.
Are you sure the configured username has the necessary permissions for the above actions?
For more help....(handbook link)

A more details link could also be put which can include all this red text for those who need it.

Bojhan’s picture

tixilite please read the issue comments.

sirkitree’s picture

db_set_active() is not failing - I tried to trace it back through the new classes and methods for DBTNG and it looks like there needs to be some sort of check in final protected static function parseConnectionInfo()...

yoroy’s picture

bumpscribe…

Bojhan’s picture

Doesn't seem this issue still exists, can someone verify?

aspilicious’s picture

Status: Active » Fixed
StatusFileSize
new42.07 KB

This is fixed!

See attachment, put back on active if you disagree!

Status: Fixed » Closed (fixed)
Issue tags: -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.