Moneris for Drupal 6?

I'm looking forward to this as well, but the site where I use this module is only 5.x and we have other problems we'd like to fix before we need to upgrade to 6.x...

I've done some work on updating the code to UC2/D6. From what I can tell, there were no API changes for UC2, at least any that pertain to this module, anyway.

Of course the requisite .info file and menu/form alter hook changes have been made. I can say with some confidence that the core functionality is working - I have yet to test CVV or Verified by Visa functionality. The reason I'm concerned about those is that there have been some changes to the form alter, validation and submission functions and I'm not sure that I've correctly altered the code to flow correctly. Please test and let me know.

Thanks for your work on this. A couple notes:

1) It would be best to post a cleanup patch separately so that it can be applied to both 5.x and 6.x.
2) The patch seems to be slightly out of date - it reverses the work done in #373043: if curl is not available, might as well fail early
3) A patch is better than a tar.gz

So, I split out the cleanup to #419618: general Drupal standards cleanup for moneris. Can you review that? If it looks good to you I will commit it to both branches and then we can distill this patch down to the changes that are really important for 6.x.

I didn't even realize that there was a UC_Moneris project on drupal.org until I looked to post code. I used the original version posted on Ubercart.org to develop this, so the two patches posted here (curl and cleanup) were not included originally.

I also did some code cleanup, probably very similar to your patch, greggles. If you apply this patch against the latest dev 5.x version is should incorporate the curl patch as well, as I applied that patch before diffing this one. It's really difficult to separate all of the changes I made that are D6 migration tasks and the ones that are just code cleanup, so if we branch before your code cleanup patch we'd be better off I think.

PS..This patch made outside the uc_moneris directory because of the changes to both the .info and .module files.

So, I committed #419618: general Drupal standards cleanup for moneris.

And re-rolled this one. I added two "TODO" items around two things that seem like they wouldn't work. Did you test this?

There very well might be problems with it, but it works. I've tested it pretty thoroughly with Moneris' test accounts and cards. I haven't yet used it in real transactions. I'll look at your TODOs when I have the chance.

The attached patch:

- corrects addition of uc_moneris_checkout_review_form_submit as a submit function for the uc_cart_checkout_form.
- Changes greggles' TODO about just returning, rather than calling uc_cart_checkout_review_form_submit

Based on the switch in uc_moneris_checkout_review_form_submit, it looks like uc_moneris_mpi_complete() won't called from uc_moneris_checkout_review_form_submit.

Still to be addressed is the TODO regarding the call to uc_cart_checkout_review_form_submit.

For the D6 port, the curl check (see #373043: if curl is not available, might as well fail early) should be moved into hook_requirements().

It doesn't seem like there's a D6 branch yet - otherwise I would open a new issue and make a patch for this...

Here's the code that needs to go into uc_moneris.install:

/**
 * Implementation of hook_requirements().
 */
function uc_moneris_requirements($phase) {
  $t = get_t();

  $has_curl = function_exists('curl_init');
  $requirements['uc_moneris_curl'] = array(
    'title' => $t('cURL'),
    'value' => $has_curl ? $t('Enabled') : $t('Not found'),
  );
  if (!$has_curl) {
    $requirements['uc_moneris_curl']['severity'] = REQUIREMENT_ERROR;
    $requirements['uc_moneris_curl']['description'] = $t("uc_moneris requires the PHP <a href='!curl_url'>cURL</a> library.", array('!curl_url' => 'http://php.net/manual/en/curl.setup.php'));
  }

  return $requirements;
}

The curl check in uc_moneris.module will also need to be removed.

Committed to HEAD which is now the 6.x-1.x area.

http://drupal.org/cvs?commit=229228

Thanks chiddicks and ezra-g!

@TR - That's a great point. With a proper branch, now you can open that issue ;)

Hi there

Thanks for all the recent work on this. Just loading it up to have a peek but it's not compatible with 6.12. Just an FYI. Cheers!

Hmmmm....not sure what would make it incompatible. I guess it's either the hook_menu entry or the .info file.

I just committed some info file changes. Maybe this will fix it?

Guess so.