I did a fresh installation of Activity 1.1 on Drupal 6.10, but it gave me warnings. First I enabled main Activity module. No problem here. Then I enabled the submodules Activity history, Comment activity, Node activity, OG activity, User activity, User relationships activity. After enabling the module page first showed these results:

* Activity integration with Comment module installed. Go to Comment Activity settings to customize
* Activity integration with Node module installed. Go to Node Activity settings to customize
* Activity integration with Organic Groups installed. Go to Organic Groups Activity settings to customize
* Activity integration with User module installed. Go to User Activity settings to customize
* There are no relationships defined. Please define some user relationships before configuring the activity messages.
* Activity integration with User Relationships module installed. Go to User Relationships Activity settings to customize
* The configuration options have been saved.

Then it gave these warning messages:

* warning: array_keys() [function.array-keys]: The first argument should be an array in C:\Project\drupal\sites\all\modules\activity\activity.module on line 957.
* warning: Invalid argument supplied for foreach() in C:\Project\drupal\sites\all\modules\activity\activity.module on line 960.
* warning: Invalid argument supplied for foreach() in C:\Project\drupal\sites\all\modules\activity\activity.module on line 960.
* warning: Invalid argument supplied for foreach() in C:\Project\drupal\sites\all\modules\activity\activity.module on line 960.

Comments

sirkitree’s picture

sirkitree commented
Status: Active » Postponed (maintainer needs more info)

Dos this happen if you first have User Relationships installed and have at leat one relationship defined?

mcload’s picture

mcload commented

I have UR installed and there is one relationship. I uninstalled and then reinstalled submodules Activity history, Comment activity, Node activity, OG activity, User activity, User relationships activity. It did not give warnings this time. It looks like it does not happen when UR is installed and there is one relationship.

sirkitree’s picture

sirkitree commented
Title: D6 installation gives warnings » Installation warning for UR if no relationship defined
Component: Code » Activity Contrib
Status: Postponed (maintainer needs more info) » Active

We should be checking for that then.

Changing status and title to reflect the task.

jaydub’s picture

jaydub commented

Added code to check for valid relationships types before installing the UR activity module defaults. Comitted to CVS and will be in the next -dev and shortly in a new release.

sirkitree’s picture

sirkitree commented
Issue tags: +activity-6.x-1-2

Tagging for next point release.

jaydub’s picture

jaydub commented
Status: Active » Fixed

if no relationships are defined, the Activity UR defaults are not installed since there are no relationships to based default activity records on. The menu option for the Activity UR settings is not shown either until relationships have been defined.

Status: Fixed » Closed (fixed)
Issue tags: -activity-6.x-1-2

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +activity-6.x-1-2

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.