Login to slave domain does not propagate to master domain on a translated drupal installation

Henrik Opel - March 25, 2009 - 11:50
Project:Shared Sign-On
Version:6.x-1.3
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

The automatic propagation of a log in to a slave site back to the master site does not work, if the String 'Log in' (used for the log in forms) is translated.

The error is caused by the t() function not being available at the time SSO checks for 'are we in the middle of logging in' in singlesignon_boot(). Even though there is an explicit check for function_exists('t'), the fallback if this is not the case is simply to use the untranslated string, which obviously will not work for translated strings.

#1

Henrik Opel - March 25, 2009 - 12:06
Status:active» needs review

The attached patch changes the checking logic to use the possible log-in form ids ('user_login' and 'user_login_block'), which do not change for translated installations.

This fixes the issue by removing the need for the t() function being available.

AttachmentSize
singlesignon-413218-1.patch 896 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.