Posted by Mark Theunissen on March 25, 2009 at 5:14pm
| Project: | Goofy |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
The following line in table.tpl.php:
$attributes['class'] .= ' sticky-enabled';
Causes havoc in the theme. It makes all node titles sticky, so it looks like the headings follow you down the page as you go. Only with Javascript enabled, of course.
I don't mean to be impolite, but are you aware that you shouldn't have all your logic in .tpl.php files? This theme breaks many, many Drupal coding conventions and standards and it's pretty ugly in there!
Comments
#1
#2
There is indeed a problem with sticky headers and some uses of theme_table.
Beyond this, believe it or not, there is significantly less "logic" in the templates than there used to be when I started evolving it.
It *is* indeed rather ugly code-wise, though, and I expect this to improve over time, but due to its bizarre construction of tables with additional rows and columns to create the borders, it is extremely unlikely it will really be clean some day. This is an early Drupal theme being ported, not a modern construction, and it shows.
#3
Ok great! No offence meant. I'm not blaming anyone for the code, I just wanted to make sure that somebody was aware of it's quality... ;)