Closed (fixed)
Project:
Advanced Forum
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Mar 2009 at 17:50 UTC
Updated:
27 May 2010 at 21:19 UTC
Hello,
Just wanted to hear your opinion,
I had a validation issue because of the comment.module using :
$output .= "<a id=\"comment-$comment->cid\"></a>\n"; (on line 1573)
and the advf-forum-post.tpl.php using :
<div id="comment-<?php print $comment->cid; ?>" class="forum-post <?php print $classes; ?> clear-block"> (on line 34)
so I have changed this line to :
<div class="comment-<?php print $comment->cid; ?> forum-post <?php print $classes; ?> clear-block">
What do you think ?
Will this cause any other issues ?
Comments
Comment #1
michelleI don't think that will cause any other issues. I guess try it and see... I'm no CSS expert.
Michelle
Comment #2
bastos commentedit is invalid HTML. Please fix.
Comment #3
michelleI have no control over what the comment module does. I'll revisit if there's something better AF could be doing in 2.x.
Michelle
Comment #4
michelleComment #5
michelleFixed in my copy... Didn't commit it right away like I should have and now I have some other unfinished stuff so it will go in a mish mash commit tomorrow.
Michelle
Comment #7
Rael commentedI have the same issue. What about using
<a name="">instead of<a id="">for anchors ?