Hello,
Just wanted to hear your opinion,
I had a validation issue because of the comment.module using :
$output .= "<a id=\"comment-$comment->cid\"></a>\n"; (on line 1573)
and the advf-forum-post.tpl.php using :
<div id="comment-<?php print $comment->cid; ?>" class="forum-post <?php print $classes; ?> clear-block"> (on line 34)
so I have changed this line to :
<div class="comment-<?php print $comment->cid; ?> forum-post <?php print $classes; ?> clear-block">

What do you think ?
Will this cause any other issues ?

Comments

michelle’s picture

Status: Active » Fixed

I don't think that will cause any other issues. I guess try it and see... I'm no CSS expert.

Michelle

bastos’s picture

Status: Fixed » Active
Issue tags: +XHTML validation

it is invalid HTML. Please fix.

michelle’s picture

Version: 6.x-1.0-rc4 » 6.x-1.x-dev
Category: support » feature
Status: Active » Postponed

I have no control over what the comment module does. I'll revisit if there's something better AF could be doing in 2.x.

Michelle

michelle’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
Category: feature » task
Status: Postponed » Active
michelle’s picture

Status: Active » Fixed

Fixed in my copy... Didn't commit it right away like I should have and now I have some other unfinished stuff so it will go in a mish mash commit tomorrow.

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Rael’s picture

I have the same issue. What about using <a name=""> instead of <a id=""> for anchors ?