Node edits fail when imceimage field is empty

If you have a content type with an optional (not required) imceimage field, leaving the field empty then saving the node works fine. However, if you then try to edit the node but still leave the imceimage field empty, the update fails. This is because hook_content_is_empty only checks whether imceimage_path is set (which at first glance seems sensible because this is the only user-editable field - _width, _height and _alt are all hidden fields).

Here's what happens.

• On initial node creation, content.module (CCK) fires hook_content_is_empty, receives TRUE, so populates empty fields with default values from Schema. Default values of 0 are set for imceimage_width and _height.
• On node edit, hook_content_empty fires again. imceimage module checks imceimage_path, which is still not set, so reports again that all fields are empty. Only this time, it's not true. imceimage_width and _height now contain the default value, 0. CCK is told that the fields are empty so it populates the database UPDATE query with NULL for all four imceimage fields. The query fails because imceimage_width and imceimage_height are set to NOT NULL.

The solution is to tighten up the check in imceimage_content_is_empty to report FALSE if any field is not populated, not just imceimage_path:

/**
 * implementation of hook_content_is_empty..
 **/
function imceimage_content_is_empty($item, $field) {
  $emptyCheck = ($item['imceimage_path'] === '' &&
                 $item['imceimage_width'] === '' &&
                 $item['imceimage_height'] === '' &&
                 $item['imceimage_alt'] === ''
                 );
  return $emptyCheck;
}

A patch is attached.

As a side issue, I think CCK is also at fault here. Even if imceimage isn't being entirely honest about whether the field values are empty, CCK should still check for default values where NULL on UPDATE as well as INSERT queries.