Missing </div> causes layout troubles in Safari

mikl - March 25, 2009 - 20:34
Project:Office Hours
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:mikl
Status:closed
Description

I've been trying out this module for a project, and I had some issues editing the CCK field in Safari.

Basically, most of the form and half the page was missing:
http://www.quicksnapper.com/mikl/image/untitled-0000

I figured it was a mismatched tag problem, and so I ran it through the HTML validator at http://validator.w3.org/. Here's what it found:
http://www.quicksnapper.com/mikl/full/untitled/

#1

Ozeuss - March 25, 2009 - 20:48

You're right, there is indeed a missing closing . Somehow FF managed to hide it. Will be commited soon

#2

mikl - March 26, 2009 - 09:07
Assigned to:Anonymous» mikl
Status:active» needs review

I've made a patch for this, using #prefix and #suffix.
In my opinion that is a safer way to add div-wrappers – if you have it as a form element, form elements can "escape" if their weight is adjusted :)

AttachmentSize
0001-Bugfix-closing-wrapper-div.-http-drupal.org-node.patch 1.3 KB

#3

Ozeuss - April 4, 2009 - 12:31
Status:needs review» fixed

Thanks, I've implemented this with a slight modification.

#4

System Message - April 18, 2009 - 12:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.