In uc_order_action_email(), token replacement is done on $settings['from'], but the result ($addresses) is overwritten and therefore never used.

  // Apply token replacements to from and recipient e-mail addressses.
  $addresses = token_replace_multiple($settings['from'], $settings['replacements']);
  $addresses = token_replace_multiple($settings['addresses'], $settings['replacements']);

Were tokens truly intended to be supported for this field?

CommentFileSizeAuthor
#1 413972.from_fix.2.x.patch1.16 KBcha0s

Comments

cha0s’s picture

Status: Active » Needs review
StatusFileSize
new1.16 KB

Thanks for the report. On first glance, it looks like it should be like this:

rszrama’s picture

Assigned: Unassigned » Island Usurper
Island Usurper’s picture

Status: Needs review » Fixed

Looks good to me. Committed.

Status: Fixed » Closed (fixed)
Issue tags: -token

Automatically closed -- issue fixed for 2 weeks with no activity.