More informative message when Error Reporting is not set up properly

EvanDonovan - March 26, 2009 - 18:35
Project:CustomError
Version:6.x-1.1
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active
Description

It would be helpful if the error message that CustomError returns when Error Reporting is not set up properly would say how to fix the problem. Something like:

<?php
   
if (variable_get('site_' . $code, '') != 'customerror/' . $code) {
     
drupal_set_message(t('Error reporting is not set for error !error. Please ensure that the default !error page is set to be customerror/!error at !link.', array('!error' => $code, '!link' => l(t('here'), 'admin/settings/error-reporting'))), 'error');
    }
?>

#1

brad bulger - March 28, 2009 - 22:24
Version:6.x-1.1» 5.x-1.2

Agreed. For example, we are using LoginToboggan, and 403 errors point to its "toboggan/denied" page. Which is not the CustomError page, and so it says "Error reporting is not set". Which confuses my users to no end, because there is "error reporting" set up - it's just not the CustomError flavor. Language that was a bit more specific, and more of a warning/notice, would be helpful. Like:

To use the CustomError settings for 403 errors, you must go to the Error Reporting page and set the path for 403 errors to "customerror/403"

or some such. I realize how difficult it is to write a universally unambiguous sentence.

Somewhat of a secondary issue: I noticed that if I removed all the values for 403 errors - no title, no text, nothing - I still get the "Error reporting is not set" message. You might consider removing it in that circumstance.

#2

brad bulger - April 2, 2009 - 00:34
Version:5.x-1.2» 6.x-1.1

sorry, thought it would just add the 5.x-1.2 version, not change the main one.

#3

EvanDonovan - April 2, 2009 - 14:45

No problem. I wish that this interface provided a way to indicate that an issue applies to multiple versions, especially when the module is essentially the same on 5.x and 6.x.

 
 

Drupal is a registered trademark of Dries Buytaert.