Comments "disappear" if they contain words of the banlist

miruoss - March 26, 2009 - 21:55
Project:abuse
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:BTMash
Status:active
Description

Sometimes comments are unpublished but not added to any moderation queue. I think it happens if the following pre-conditions are met.

  • Comments are not pre-moderated
  • The user submitting the comment doesn't have the "direct flag" permissions
  • The comment contains words of the banlist
  • The abuse_threshold is >1

I think there is an error in _watchlist_report_generated(). What happens is the followin:

  1. if ($premoderated || $hidden) is true so the comment is unpublished
  2. afterwards if($hidden && !$premoderated) is true as well so _abuse_disable() is executed
  3. _abuse_disable() doesn't do anything because the user has no "direct flag" permission and the threshold is not met

So the comment is unpublished because of 1. but will not be abuse_state is never set. The comment just "vanishes".

#1

BTMash - October 23, 2009 - 18:03
Assigned to:Anonymous» BTMash

Not sure if you are using the module anymore or not...I have finally gotten around to try and start fixing up the module. I see what you are referring to. I am going to look at the code to figure out a patch regarding this. Thank you.

 
 

Drupal is a registered trademark of Dries Buytaert.