regression from 4.6.x

CommentFileSizeAuthor
#12 profile.module_16.patch6.85 KBrkerr
#10 profile.module_15.patch6.13 KByched
#7 profile_hidden.diff2.32 KBmunga
#1 profile.diff6.87 KBmunga

Comments

munga’s picture

munga commented
StatusFileSize
new profile.diff6.87 KB

The attached patch should fix the problem ...

munga’s picture

munga commented

Reg that pacth I've just submitted ...

I'm not sure if it's the right way to solve the problem and
I haven't managed to make the category disappear if all fields in that
category are hidden ... I think the category tab is set in user.module.

Steve Dondley’s picture

Steve Dondley commented

I don't understand this bug report. Why should a hidden or private field be removed from the user edit form? User's should always be able to edit these fields regardless of the "Visibility" setting.

merlinofchaos’s picture

merlinofchaos commented

Because 'hidden' fields are not meant to be user editable, but should only be edited by admins, modules or themes.

It's useful for things like Titles that admins can give users. I don't want users editing their titles if they have meaning, for example!

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Active » Needs review

what #4 says

setting patch status for patch in #1

Steve Dondley’s picture

Steve Dondley commented
Status: Needs review » Needs work

Code for form elements should span several lines instead of being bunched onto one.

munga’s picture

munga commented
StatusFileSize
new profile_hidden.diff2.32 KB

new patch attached. This one contains only the small patch for the hidden files (and
this time in the correct order). I left any other modifications out.

p

yched’s picture

yched commented

I'd like very much this bug to be fixed :-)
Could you provide an update of your patch against current head ?

darius’s picture

darius commented
Title: setting profile field to hidden or private does not remove it from the user edit form » setting profile field to hidden does not remove it from the user edit form

The issue is real (I just verified this with the latest CVS version), but the patch does not apply cleanly anymore. Also, the related issue could be addressed here, too: admins SHOULD see the hidden fields in VIEWING user profile (currently, the issue only addresses what happens in EDITING user profile).

Darius

P.S. I removed "private" from the title because this only concerns "hidden" fields.

yched’s picture

yched commented
Status: Needs work » Needs review
StatusFileSize
new profile.module_15.patch6.13 KB

OK, I updated the last patch submitted by munga. It is now synched with current HEAD.

I also spanned the code for form elements on several lines as Steven requested.

Seems to work for me, but I haven't done extensive testing.

rkerr’s picture

rkerr commented

Bug still exists but patch does not apply.

""
patching file modules/profile.module
patch: **** malformed patch at line 102: @@ -400,11 +446,17 @@
""

rkerr’s picture

rkerr commented
StatusFileSize
new profile.module_16.patch6.85 KB

Updated patch against most recent HEAD.

Amazon’s picture

Amazon commented

I created a new profile field in a profile.

I could see the profile field as admin for a hidden profile.

I could not see if as an authenticated user looking at my own profile.

I only tested after the patch was applied, I did not test without the patch.

Kieran

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

kieran tested this so lets move to RTC

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)