Search field and button unaligned; patch for pushbutton and bluemarine

Dunno if this is the way to submit fixes, But I'll give it a try anyway.

I've been studying the styles.css file of the pushbutton theme, in order to find a fix for the unaligned search field and button. I'm no css expert, so this fix is based purely on experimentation, but it works.

Here's what I came up with :

Find this:

#search .form-text, #search .form-submit {
  border: 1px solid #369;
  font-size: 0.85em;
}
#search .form-text {
  width: 8em;
  height: 1.4em;
  padding: 0 0.5em 0 0.5em;
  margin: 0 0 0.5em 0;
}
#search .form-submit {
  height: 1.5em;
}

and replace with this

#search .form-text, #search .form-submit {
  margin: 4px 0px 4px 0px;
}
#search .form-text {
  width: 8em;
}
#search .form-submit {
}

The result looks fine in opera, firefox and ie, and w3c validates - see attached screenshot.

You may check the result out yourself here: http://drupaldanmark.dk/

Best regards
Bjarne

Actually, the same fix works for the blumemarine theme (see attached screenshot).

In /themes/bluemarine/style.css

Find:

#search .form-text, #search .form-submit {
  border: 1px solid #369;
  font-size: 1.1em;
}
#search .form-text {
  width: 8em;
  height: 1.4em;
  padding: 0 0.5em 0 0.5em;
  margin: 0 0 0.5em 0;
}
#search .form-submit {
  height: 1.5em;
}

Replace with:

#search .form-text, #search .form-submit {
  margin: 4px 0 4px 0;
}
#search .form-text {
  width: 8em;
}
#search .form-submit {
}

Again, I have tested in latest versions of Opera, Firefox and IE6.
//Bjarne

#3 - well, heres a try. Testing several windows cvs frontends, I found that only TortoiseCVS fitted my needs and was easy to use (http://drupal.org/node/22293)

Here's a patch for the pushbutton theme (also attached)

Index: themes/pushbutton/style.css
===================================================================
RCS file: /cvs/drupal/drupal/themes/pushbutton/style.css,v
retrieving revision 1.12
diff -u -r1.12 style.css
--- themes/pushbutton/style.css	2 Sep 2005 19:18:14 -0000	1.12
+++ themes/pushbutton/style.css	4 Jan 2006 11:34:00 -0000
@@ -207,16 +207,13 @@
 }
 #search .form-text, #search .form-submit {
   border: 1px solid #369;
-  font-size: 0.85em;
+  font-size: 0.85em;  
+  margin: 0.3em 0 0.3em 0;
 }
 #search .form-text {
   width: 8em;
-  height: 1.4em;
-  padding: 0 0.5em 0 0.5em;
-  margin: 0 0 0.5em 0;
 }
 #search .form-submit {
-  height: 1.5em;
 }
 #mission {
   background-color: #fff;

#4, hmm. fixed pixelheight for margins are used in several other places in the stylesheet, but, now i've chose a 0.3em margin instead of a 4px margin - is that what you meant?- results are fine in firefox, opera and ie, and w3c validates.

And here is a patch for the bluemarine theme:

Index: themes/bluemarine/style.css
===================================================================
RCS file: /cvs/drupal/drupal/themes/bluemarine/style.css,v
retrieving revision 1.11
diff -u -r1.11 style.css
--- themes/bluemarine/style.css	2 Sep 2005 19:18:14 -0000	1.11
+++ themes/bluemarine/style.css	4 Jan 2006 11:44:27 -0000
@@ -114,16 +114,13 @@
 }
 #search .form-text, #search .form-submit {
   border: 1px solid #369;
-  font-size: 1.1em;
+  font-size: 1.0em;  
+  margin: 0.3em 0 0.3em 0;
 }
 #search .form-text {
   width: 8em;
-  height: 1.4em;
-  padding: 0 0.5em 0 0.5em;
-  margin: 0 0 0.5em 0;
 }
 #search .form-submit {
-  height: 1.5em;
 }
 #mission {
   background-color: #369;

I hope that this can help.

//Bjarne

Hi folks

This cosmetic glitch still applies to beta 3.

Regards
Bjarne

Same issue applies to beta 4 ;-)

Aaaaaah, you guys. Not only do you want us drupal fans to help fixing the bugs, you also want us to do it right! - now what kind of attitude is that ;-)

I'm a totally css ignorant, all my html knowledge dates back to 1998 where css's were "future technology" (at least to me) - so the patch I came up with, was merely the fortunate results of trial and error. So, the hint "find out where the margin comes from", does not mean much to me. Still, I would be happy to dig more into this and see if I can come up with a patch that satisfies - but don't hold your breath :-)

Kind regards
Bjarne