Download & Extend
Masquerade » Issues

Undefined index: masquerading when login in

Posted by beginner on March 27, 2009 at 8:47am
Project:Masquerade
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

* notice: Undefined index: masquerading in masquerade.module on line 125.
* notice: Undefined index: masquerading in masquerade.module on line 123.

<?php
function masquerade_access($type) {
  switch ($type) {
    case 'unswitch':
      return $GLOBALS['masquerading'] || arg(2) == 'menu-customize' || arg(2) == 'menu';
    case 'autocomplete':
      return $GLOBALS['masquerading'] || (user_access('masquerade as user') || user_access('masquerade as admin'));
      break;
    case 'switch':
      return empty($GLOBALS['masquerading']) && (user_access('masquerade as user') || user_access('masquerade as admin'));
      break;
  }
}
?>
Login or register to post comments

Comments

#1

Posted by beginner on March 27, 2009 at 8:55am

In case 'unswitch' and 'autocomplete', would the following be the intended behavior?

<?php
return !empty($GLOBALS['masquerading']) || ... etc.
?>

Are you sure that the case 'unswitch' is secure enough?

#2

Posted by deekayen on June 20, 2009 at 4:57am
Status:active» fixed

I'm not sure what Gurpartap intends there, but I wrapped the globals with empty checks in 6--1.

#3

Posted by System Message on July 4, 2009 at 5:00am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.