Module failes to migrate (though seems close)

Dinis - March 27, 2009 - 09:02
Project:Deadwood
Version:6.x-1.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:solotandem
Status:needs review
Description

Hi,

I'm trying to migrate the excellent (but no longer supported) search_attachments module to Drupal 6.

Deadwood has a good stab at it, but the module white screens when trying to access the "helper" settings and seems to break the cron.

Anyone able to help? I've attached the before and after files.

I'm getting so desperate to get file indexing working on Drupal 6 I'll consider paying somone if they can do a good job.

Cheers,
Danielle

AttachmentSize
search_attachments_deadwood.zip36.03 KB
search_attachments_goodwood.zip36.28 KB

#1

solotandem - March 29, 2009 - 20:14
Assigned to:Anonymous» solotandem
Status:active» needs review

You appear to have run Deadwood on files already run through Deadwood as there are duplicate copies of certain changes and comments. Deadwood should always be run on the 5.x files.

I made the following changes to the code output by Deadwood (most of these are mentioned in the comments added by Deadwood to the top of the file):

search_attachments.module
-------------------------
Replace calls to db_next_id with db_last_insert_id
- You need to fix the second parameter to this function
- You may also need to set auto increment field in schema

Fixed duplicated name of module_load_include (from running Deadwood twice)

Uncomment search_attachments_theme function in comments added by Deadwood at top of file

search_attachments.install
--------------------------
function search_attachments_schema
- removed duplicate copy of search_attachments_schema
- removed duplicate schema entries and empty entries

function search_attachments_install
- add call to drupal_install_schema
- remove table creation statements in switch statement
- clean up quotes in queries for string parameters
- commented out references to sequences table that no longer exists in D6
- you may need to deal with sequences table no longer existing in D6

The module installs and the settings pages appear to display properly. I did not test any further. Let me know if this helps.

I will accept payment by PayPal. Send me an email from my contact page.

AttachmentSize
search_attachments.zip 34.33 KB

#2

Dinis - March 27, 2009 - 19:18

Superb response :)

My bad on the attachments, I must have mixed the files up (I'm guessing the deadwood version has had one pass already).

I've sent you an email.

Kind regards,
Danielle

#3

Dinis - April 1, 2009 - 09:56

I've done some testing today, the helper edit pages are still failing (which are fairly critical to the module running). Trying to access one (e.g. http://site/admin/settings/search_attachments/edit/1) will return a broswer error.

If I manually enter the details for helpers into the database by copying a working 5.x install, they will appear in the helper list but do not function or index any content.

This appears to be *so* close to working :)

Kind regards,
Danielle

P.S. I've sent you a couple of emails, I would like to work out some payment for your work.

 
 

Drupal is a registered trademark of Dries Buytaert.