When using one way pre-approved relationships (or any pre approved relationships) currently there is no option of an email alert. This patch adds that functionality.

CommentFileSizeAuthor
#3 user_relationship_mailer.module.20091130.patch487 bytesgoz
user_relationships_pre_approved_email.patch2.9 KBa_c_m

Comments

alex.k’s picture

alex.k commented
Assigned: Unassigned » alex.k
Status: Needs review » Fixed

Committed with small changes and coder.module fixes. I also added a hook_update() function, so that sites upgrading from an earlier version of User Relationships do not start sending these out by default. Just keeping behavior consistent. New installations will have this enabled by default.

Thank you very much!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

goz’s picture

goz commented
Title: Email on creation of pre-approved relationship » Email on creation of pre-approved relationship and user_relationship_mailer_send_pre_approved option settings
Version: 6.x-1.0-beta9 » 6.x-1.x-dev
Category: feature » bug
Status: Closed (fixed) » Active
StatusFileSize
new user_relationship_mailer.module.20091130.patch487 bytes

pre-approved doesn't take user_relationship_mailer_send_pre_approved settings option.

In admin/user/relationships/settings, when "Send Pre-approved messages" is unchecked, users received an email.

I make a patch to fix it.

alex.k’s picture

alex.k commented
Status: Active » Needs review
fabianx’s picture

fabianx commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community
Issue tags: +user_relationships_mailer user_relationships_default

Please apply this patch, else the functionality of the default module breaks, which is sending out wrong mails, which all new users get spammed with.

I put priority to critical as it renders usage of default module with mailer module unusable and is a critical flaw in original patch of this thread.

And I know this patch works as I just created the same patch myself and then I found the same already here ...

The patch also is really tiny and it is only logical that the check needs to be redone, when $op is changed again, so it is a trivial change.

Best Wishes,

Fabian (LionsAd)

victoria_b’s picture

victoria_b commented

Hi,

I'm not much of a coder but looking through the latest dev version of this module against this patch - it looks like not all of it has been applied.

Alex, Please could you inform me of the status of this patch? do I need to apply it against the latest dev version?

alex.k’s picture

alex.k commented
Status: Reviewed & tested by the community » Fixed

Indeed it had not been applied. I committed a different patch that does the same thing http://drupal.org/cvs?commit=373646 (to avoid calling variable_get twice). Please check it out.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

white_pawn’s picture

white_pawn commented

I can't turn it off. That is, I deselect "Send Pre-approved messages", but the e-mails still come in. My pre-approved relationship is created via rules on user registration.

Could anyone please tell me where the variable is stored? Perhaps I could turn it off "manually", or something. Thanks.

oxford-dev’s picture

oxford-dev commented

Same problem here. Would really like to fix this.