['#ahah_helper']['#file'] is non-existent!
cha0s - March 27, 2009 - 13:20
| Project: | AHAH helper |
| Version: | 6.x-6.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | cha0s |
| Status: | closed |
Jump to:
Description
Dunno how this wasn't caught, since I couldn't even get the module to work without fixing this bug. Anyways, ahah_helper.module:145, #file should be file. I attached a patch here for that.
P.S. Great module! :)
| Attachment | Size |
|---|---|
| file_fix.patch | 841 bytes |
#1
A patch for this typo is already submited at #380312: Only AHAH javasript settings are send back and several other issues. You might want to check, if the patch, which fixes also another problem, works for you. If so, consider giving a feedback.
#2
Isn't it better to limit the scope of patches?
I don't know about the other patch, but it'd be nice to get this fix in. Thanks.
#3
Yes, I agree in general. But since there were at least 3 patches fixing the "#file"-problem I wanted to focus the (patch) review on one issue because I thought that would speed up the process of the module maintainance...
#4
Looks like issue #380312: Only AHAH javasript settings are send back is not moving forward and atleast for some part of the patch there is reservation expressed by maintainer (see comment#5).
So can we please, atleast move this patch forward as standalone and not getting caught with other issue's speed?
can someone please confirm this is working for them?
#5
Same issue and same patch is here... #368328: caching of built forms prevents form_state['values'] to be populated from $_POST, but title of this issue fits better.
I can confirm that this patch is working on the clean install of the Drupal 6.13.
#6
#7
Done. Finally.
Commit: http://drupal.org/cvs?commit=264520.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.