['#ahah_helper']['#file'] is non-existent!

Posted by cha0s on March 27, 2009 at 1:20pm

Issue Summary

Dunno how this wasn't caught, since I couldn't even get the module to work without fixing this bug. Anyways, ahah_helper.module:145, #file should be file. I attached a patch here for that.

P.S. Great module! :)

Attachment	Size
file_fix.patch	841 bytes

Comments

#1

Posted by frenkx on April 1, 2009 at 10:17am

Status:

needs review

» closed (duplicate)

A patch for this typo is already submited at #380312: Only AHAH javasript settings are send back and several other issues. You might want to check, if the patch, which fixes also another problem, works for you. If so, consider giving a feedback.

#2

Posted by cha0s on April 6, 2009 at 4:29pm

Isn't it better to limit the scope of patches?

I don't know about the other patch, but it'd be nice to get this fix in. Thanks.

#3

Posted by frenkx on April 7, 2009 at 8:06am

Yes, I agree in general. But since there were at least 3 patches fixing the "#file"-problem I wanted to focus the (patch) review on one issue because I thought that would speed up the process of the module maintainance...

#4

Posted by ajayg on August 31, 2009 at 3:40am

Status:

closed (duplicate)

» needs review

Looks like issue #380312: Only AHAH javasript settings are send back is not moving forward and atleast for some part of the patch there is reservation expressed by maintainer (see comment#5).

So can we please, atleast move this patch forward as standalone and not getting caught with other issue's speed?

can someone please confirm this is working for them?