Patch. Chart: legend's position

sullix - March 27, 2009 - 14:03
Project:Chart API
Version:6.x-1.2
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Here, a patch to add the "chdlp" option[1] (legend's position).
It introduces the variable: $chart['#legend_position'] (possible values for Google Chart: b, t, tv, bv, r, l - one value)

Could it be integrated on a future version of Chart ?

[1] http://code.google.com/intl/fr/apis/chart/labels.html#chart_legend

AttachmentSize
chart.patch960 bytes

#1

boombatower - June 18, 2009 - 18:35
Status:active» needs work

Would seem that the positions should be turned into constants.

#2

awolfey - October 7, 2009 - 21:12
Status:needs work» needs review

Here's a patch against HEAD with positions as constants.

AttachmentSize
chart.module-legend-position.patch 1.57 KB

#3

boombatower - October 21, 2009 - 04:23
Status:needs review» fixed

+++ chart.module 7 Oct 2009 21:10:16 -0000
@@ -58,6 +58,16 @@
+* Legend Position
+*/

Need spaced in.

+++ chart.module 7 Oct 2009 21:10:16 -0000
@@ -289,6 +299,7 @@
+  _chart_append('chdlp',$chart['#legend_position'],        $data);

A bit off, needs a space.

Made changes and committed, thanks.

I'm on crack. Are you, too?

#4

System Message - November 4, 2009 - 04:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.