Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The custom block title added in bug node/34023 wasn't compatible with 4.7 forms and also introduced a couple of undesirable debug print statements. The 4.6 packaged version of this module in fact works on 4.7 without modification. The changes to HEAD last week to add the custom title broke the module for 4.7.
Here's a patch to bring it back. It uses the new forms interface for the custom title and removes two dprint_r debugging statements when the custom title is saved.
It works fine for me, but I'd appreciate a review. I only fixed what was obviously broken, and have not scrutinized the module for any other potential upgrade issues.
| Comment | File | Size | Author |
|---|---|---|---|
| tagadelic.patch | 877 bytes | macgirvin |
Comments
Comment #1
macgirvin commentedI initially assigned this bug to myself, since I had a patch. But I am not qualified to review it. Un-assigning.
Comment #2
Bèr Kessels commentedSome small hints, and ideas (but wait with re-doing this patch, I am working on it now)
* use the -u flag when diffing: more on drupal.org/diffandpatch
* I try as much as possible to make formapi arrays readable, one-line array defs are clutter, ugly and unreadable.
Try array (
'foo' => $bar,
'far' => $boo,
)
note the last , comma, and the two space indent.
Comment #3
Bèr Kessels commentedCommitted a modified patch, thank you!
Comment #4
Bèr Kessels commentedComment #5
(not verified) commented