Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Trailing space and indentation fix.
No functional change..
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 415944-8-code_style.patch | 8.09 KB | pasqualle |
| #6 | 415944-6-code_style.patch | 23.82 KB | pasqualle |
| #4 | 415944-4-code_style.patch | 52.06 KB | pasqualle |
| #2 | 415944-2-code_style_l10n_groups.patch | 8.38 KB | pasqualle |
| code_style.patch | 73.35 KB | pasqualle |
Comments
Comment #1
gábor hojtsyGood. I'd be happy to commit such fixes if there were no major patches waiting in the queue. As it stands, committing this patch would only break those patches, however those improve on performance which is more important for drupal.org deployment in the short run. Maybe help out testing there? :)
Comment #2
pasquallemany code style fixes were committed since then, so starting over.
this patch is for l10n_groups module only; with the following changes:
1. no need to pass $node by reference in hook_insert/update/delete
2. do not translate schema descriptions
3. fixed some comments
4. trailing spaces
Comment #3
gábor hojtsyThanks, committed.
Comment #4
pasquallechanges in this patch:
1. trailing spaces
2. indentation
3. some weird line breaks
4. else if
Comment #5
gábor hojtsy$ patch -p0 < 415944-4-code_style.patch.txt
patching file l10n_community/export.inc
patching file l10n_community/import.inc
patching file l10n_community/l10n_community.module
patching file l10n_community/moderate.inc
patch: **** malformed patch at line 254:
Comment #6
pasquallepatch #4 works for me.
the problem might be the windows style line ends in some parts of the moderate.inc and translate.inc files. It seems like I can't really make a working patch for you for those files, it would be nice if you could fix the line break problems in those files.
this patch is the same as #4, just the problematic files are removed from it..
Comment #7
gábor hojtsyOk committed this with the re-saved translate.inc and moderate.inc with Unix newlines. Thanks again.
Comment #8
pasqualleok, the line breaks seems good now
and the remaining trailing spaces from these files.
(yes it is my IDE creating these patches, you should find this setting also)
Comment #9
gábor hojtsyCommitted with even more of these fixes, thanks.