Feature request already! This is fantastic and will really help using advanced_help to document projects, which I had already started to do the old way.

Do you see it possible, however, to allow this to operate in a more organic fashion– to click the plus icon and make the book page from there?

This is as opposed to writing all the text, then enabling the module and trying to match it up.

benjamin, Agaric Design Collective

CommentFileSizeAuthor
#6 book-link.patch1.14 KBcrashtest_
#5 416068-book-link.patch1.15 KBcrashtest_
#3 416068-book-link.patch892 bytescrashtest_
#2 416068-book-link.patch887 bytescrashtest_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertDouglass’s picture

robertDouglass CreditAttribution: robertDouglass commented

Yes. Good suggestion. I'm going to make a TODO: in the code referencing this issue as part of my effort to document all of the TODOs and issues before moving forward.

crashtest_’s picture

crashtest_ CreditAttribution: crashtest_ commented
Status: Active » Patch (to be ported)
FileSize
416068-book-link.patch887 bytes

It may be useful to use the current model, especially if you have to use the same help in several places. In place of this, I think that adding a link to create a book page "Choose the book page that should be used for this item or create a new help." seems like a good way to go.

Patch attached.

crashtest_’s picture

crashtest_ CreditAttribution: crashtest_ commented
FileSize
416068-book-link.patch892 bytes

Actually I suppose it should be worded "or create a new book page."

robertDouglass’s picture

robertDouglass CreditAttribution: robertDouglass commented
Status: Patch (to be ported) » Needs work

This is a good interim solution. Whenever you're doing a t() string, the goal is to provide the translator with an overview of the whole phrase that needs to be translated. For example, the phrase t('Choose the book page that should be used for this item, or ') can't really be translated because there is no context for the second clause. For this purpose t() supports replacements. t("Hand me that @thing", array('@thing' => $thing)); This gives the translator ample context, and all they have to do is leave @thing in the right place in the sentence and they're free to translate away. So you can do the same thing here with the l() part of the t() string.

[#144488] says that to make a link to a full HTML page appear in a lightbox you just need to add rel="lightframe". Adding this to the link would be great usability win because then you'd never even navigate away from the page you're on.

"Patch to be ported" is the status you give patches when they need to be adapted to different branches or point releases (like when they commit something to D7 and then decide it should go into D6 as well).

crashtest_’s picture

crashtest_ CreditAttribution: crashtest_ commented
FileSize
416068-book-link.patch1.15 KB

Here you go. Thanks for the tips, and the heads-up on what "Patch to be ported" stands for.

crashtest_’s picture

crashtest_ CreditAttribution: crashtest_ commented
FileSize
book-link.patch1.14 KB

Fixing broken patch.

robertDouglass’s picture

robertDouglass CreditAttribution: robertDouglass commented
Status: Needs work » Fixed

Thanks! Committed.

crashtest_’s picture

crashtest_ CreditAttribution: crashtest_ commented
Status: Fixed » Active

I am re-opening this issue. The original idea of this issue is still valid.

A user should be able to click the + to arrive at one form where they are able to type in their help.

This form should have an expandable region with a view that allows them to select existing help items if they so choose, however the main component should be the text box where they are able to immediately type in their help text, and choose to have this text to immediately appear as either an advanced help type of pop-up page, or an inline help below the element that was selected.