The current behavior is that My favorites are displayed even if there are no favorites, or if the number of favorites to display is set to 0. The attached patch changes this so that the heading is not displayed unless there is something to display.

Note that I have removed line 145
'#value' => theme('item_list', $items),
because $items does not exist in that context.

CommentFileSizeAuthor
#5 favorite_nodes.module.patch603 bytespavithra
#4 favorite_nodes.module.patch507 byteszorp
favorite_nodes.module.patch1.26 KBrares

Comments

rares’s picture

rares commented
Status: Active » Needs review
kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

zorp’s picture

zorp commented
Status: Closed (fixed) » Active
StatusFileSize
new favorite_nodes.module.patch507 bytes

I had this same issue with the latest version... So went diving into the code and found that the above patch was implemented, but still a empty Favorites with a link to an empty view showed up on user profiile pages.

Found out it was due to the fact that $favorites array was created with content type name and therefor never will be empty.

i have attached a small Hack/patch that fixes it... I'm using it on my site and it works like a charm.

pavithra’s picture

pavithra commented
StatusFileSize
new favorite_nodes.module.patch603 bytes

Not working for me. The view function is not returning anything if there are no favorites ti be displayed.
Put in this patch and works for me.