Vote up/down widget can not display, no matter how setting it.

I have find the bug resided in vote_up_down_nodeapi function of vote_up_down.module file,

notice this line:

$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? <b>'alt'</b> : '';

must be corrected to

$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? <b>'_alt'</b> : '';

'alt' must be '_alt'

CommentFileSizeAuthor
#12 vote_up_down-alt-41630-12.patch721 bytesbrenda003

Comments

ddouble’s picture

ddouble commented

vote_up_down_nodeapi function of vote_up_down.module file

Modify code From

$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? 'alt' : '';

To

$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? '_alt' : '';
merto87’s picture

merto87 commented

Thanks for this issue.
Waiting for dev commit.....

dtarc’s picture

dtarc commented

Thanks for the fix.

sadist’s picture

sadist commented

i'd just downloaded the latest version and installed. i found tt this fix is still not committed yet?

brenda003’s picture

brenda003
she/her
commented

This actually seems to be in the vote_up_down_widget_form function, line 852, change:

      $style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? 'alt' : '';

to

      $style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? '_alt' : '';
benanne’s picture

benanne commented

Thanks, I was having the same problem.
Is this module still being maintained at all?

kevinquillen’s picture

kevinquillen commented

Just had to fix this myself too.

ManyNancy’s picture

ManyNancy commented
Status: Active » Reviewed & tested by the community
CarbonPig’s picture

CarbonPig commented
Version: 6.x-1.0-beta4 » 6.x-1.0-beta6

This works! Thank you very much - I'm putting the module on my site now that it seems to be working 2 patches and some styling later : ) http://carbonpig.com

Cheers,

CarbonPig

ed_conolly’s picture

ed_conolly commented

I've been ripping my eyes out for the last 4 hours over this.

This needs to be easier to find and mentioned on the module's download page.

Working now, thanks to this thread.

marvil07’s picture

marvil07 commented
Status: Reviewed & tested by the community » Active

as http://drupal.org/node/156119

brenda003’s picture

brenda003
she/her
commented
Status: Active » Needs review
StatusFileSize
new vote_up_down-alt-41630-12.patch721 bytes

Here's a patch.

marvil07’s picture

marvil07 commented
Status: Needs review » Reviewed & tested by the community

thanks for the patch

it will be commited as soon as I have clear status about this branch maintaining

marvil07’s picture

marvil07 commented

marked #577728: Alternative style doesn't work as dup

Status: Reviewed & tested by the community » Needs work

The last submitted patch, vote_up_down-alt-41630-12.patch, failed testing.

marvil07’s picture

marvil07 commented
Version: 6.x-1.0-beta6 » 6.x-1.x-dev
Status: Needs work » Fixed

not sure why testbot is failing, I have run the test in local, and all passed, so commited

Status: Fixed » Closed (fixed)
Issue tags: -Alternative Style

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Alternative Style

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.