Download & Extend
Vote Up/Down » Issues

Vote up/down widget can not display on alternative style

Posted by ddouble on March 28, 2009 at 1:23am
Project:Vote Up/Down
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:ddouble
Status:closed (fixed)
Issue tags:Alternative Style

Issue Summary

Vote up/down widget can not display, no matter how setting it.

I have find the bug resided in vote_up_down_nodeapi function of vote_up_down.module file,

notice this line:

<?php
$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? <b>'alt'</b> : '';
?>

must be corrected to

<?php
$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? <b>'_alt'</b> : '';
?>

'alt' must be '_alt'

Login or register to post comments

Comments

#1

Posted by ddouble on March 28, 2009 at 1:35am

vote_up_down_nodeapi function of vote_up_down.module file

Modify code From

<?php
$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? 'alt' : '';
?>

To

<?php
$style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? '_alt' : '';
?>

#2

Posted by merto87 on April 3, 2009 at 10:46am

Thanks for this issue.
Waiting for dev commit.....

#3

Posted by dtarc on April 7, 2009 at 2:27pm

Thanks for the fix.

#4

Posted by sadist on November 23, 2009 at 5:29am

i'd just downloaded the latest version and installed. i found tt this fix is still not committed yet?

#5

Posted by brenda003 on November 26, 2009 at 12:57am

This actually seems to be in the vote_up_down_widget_form function, line 852, change:

<?php
      $style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? 'alt' : '';
?>

to

<?php
      $style = variable_get('vote_up_down_widget_style_node', 0) == 1 ? '_alt' : '';
?>

#6

Posted by benanne on December 3, 2009 at 2:26pm

Thanks, I was having the same problem.
Is this module still being maintained at all?

#7

Posted by Kevin Quillen on January 4, 2010 at 4:54pm

Just had to fix this myself too.

#8

Posted by ManyNancy on January 6, 2010 at 4:01am
Status:active» reviewed & tested by the community

#9

Posted by CarbonPig on January 13, 2010 at 6:10am
Version:6.x-1.0-beta4» 6.x-1.0-beta6

This works! Thank you very much - I'm putting the module on my site now that it seems to be working 2 patches and some styling later : ) http://carbonpig.com

Cheers,

CarbonPig

#10

Posted by ed_conolly on February 4, 2010 at 6:27pm

I've been ripping my eyes out for the last 4 hours over this.

This needs to be easier to find and mentioned on the module's download page.

Working now, thanks to this thread.

#11

Posted by marvil07 on March 12, 2010 at 6:28am
Status:reviewed & tested by the community» active

as http://drupal.org/node/156119

#12

Posted by brenda003 on March 15, 2010 at 5:03pm
Status:active» needs review

Here's a patch.

AttachmentSizeStatusTest resultOperations
vote_up_down-alt-41630-12.patch721 bytesIdleFAILED: [[SimpleTest]]: [MySQL] 187 pass(es), 79 fail(s), and 0 exception(es).View details

#13

Posted by marvil07 on June 6, 2010 at 7:14am
Status:needs review» reviewed & tested by the community

thanks for the patch

it will be commited as soon as I have clear status about this branch maintaining

#14

Posted by marvil07 on June 6, 2010 at 7:20am

marked #577728: Alternative style doesn't work as dup

#15

Posted by System Message on June 6, 2010 at 7:30am
Status:reviewed & tested by the community» needs work

The last submitted patch, vote_up_down-alt-41630-12.patch, failed testing.

#16

Posted by marvil07 on June 8, 2010 at 9:21pm
Version:6.x-1.0-beta6» 6.x-1.x-dev
Status:needs work» fixed

not sure why testbot is failing, I have run the test in local, and all passed, so commited

#17

Posted by System Message on June 22, 2010 at 9:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here