Download & Extend

Vote up/down widget can not display on alternative style

Project:Vote Up/Down
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:ddouble
Status:closed (fixed)
Issue tags:Alternative Style

Issue Summary

Vote up/down widget can not display, no matter how setting it.

I have find the bug resided in vote_up_down_nodeapi function of vote_up_down.module file,

notice this line:

<?php
$style
= variable_get('vote_up_down_widget_style_node', 0) == 1 ? <b>'alt'</b> : '';
?>

must be corrected to

<?php
$style
= variable_get('vote_up_down_widget_style_node', 0) == 1 ? <b>'_alt'</b> : '';
?>

'alt' must be '_alt'

Comments

#1

vote_up_down_nodeapi function of vote_up_down.module file

Modify code From

<?php
$style
= variable_get('vote_up_down_widget_style_node', 0) == 1 ? 'alt' : '';
?>

To

<?php
$style
= variable_get('vote_up_down_widget_style_node', 0) == 1 ? '_alt' : '';
?>

#2

Thanks for this issue.
Waiting for dev commit.....

#3

Thanks for the fix.

#4

i'd just downloaded the latest version and installed. i found tt this fix is still not committed yet?

#5

This actually seems to be in the vote_up_down_widget_form function, line 852, change:

<?php
      $style
= variable_get('vote_up_down_widget_style_node', 0) == 1 ? 'alt' : '';
?>

to

<?php
      $style
= variable_get('vote_up_down_widget_style_node', 0) == 1 ? '_alt' : '';
?>

#6

Thanks, I was having the same problem.
Is this module still being maintained at all?

#7

Just had to fix this myself too.

#8

Status:active» reviewed & tested by the community

#9

Version:6.x-1.0-beta4» 6.x-1.0-beta6

This works! Thank you very much - I'm putting the module on my site now that it seems to be working 2 patches and some styling later : ) http://carbonpig.com

Cheers,

CarbonPig

#10

I've been ripping my eyes out for the last 4 hours over this.

This needs to be easier to find and mentioned on the module's download page.

Working now, thanks to this thread.

#11

Status:reviewed & tested by the community» active

as http://drupal.org/node/156119

#12

Status:active» needs review

Here's a patch.

AttachmentSizeStatusTest resultOperations
vote_up_down-alt-41630-12.patch721 bytesIdleFAILED: [[SimpleTest]]: [MySQL] 187 pass(es), 79 fail(s), and 0 exception(es).View details

#13

Status:needs review» reviewed & tested by the community

thanks for the patch

it will be commited as soon as I have clear status about this branch maintaining

#14

#15

Status:reviewed & tested by the community» needs work

The last submitted patch, vote_up_down-alt-41630-12.patch, failed testing.

#16

Version:6.x-1.0-beta6» 6.x-1.x-dev
Status:needs work» fixed

not sure why testbot is failing, I have run the test in local, and all passed, so commited

#17

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here