This would be awesome IMHO. I've several modules in which I've placed a .install file just because the weight needed to be changed on installation. Putting this in a .info file would be much more efficient. Something like;

; $Id:$
name = Module
description = Description
package = Other
core = 6.x
weight = 2
CommentFileSizeAuthor
#4 drupal_info_weight-416590.patch4.24 KBdawehner
#1 drupal_info_weight-416590.patch2.36 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new drupal_info_weight-416590.patch2.36 KB

this is definite a good idea,
Additional its also logical, when we have exact this in system table, that there is a weight in theme info files.

here is a first patch:
which adds weight for both modules and themes

i'm wondering where there is the documentation for info files

still needs testing using a module_test.module :), anyone know wether a module file is required for a module?

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review

oh forgot to set needs review

stborchert’s picture

stborchert
he/him
Primary language German
commented

Patch looks good and works as expected. Tested with a simple (empty and otherwise useless) module.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new drupal_info_weight-416590.patch4.24 KB

so here is a new version with a included test.
together with a module_test.info and a module_test.module with another weight

moshe weitzman’s picture

moshe weitzman commented

I don't really see any point in clutterring the .info syntax with this. Is this reread on every submission of the modules form? Do existing weight adjustments get blown away. If not, then we are inconsistent with the module name and description and dependencies.

dries’s picture

dries commented
Status: Needs review » Postponed

I think we should stay clear from adding things like weights to .info files. Their purpose is to describe the module, not to do configuration management.

skilip’s picture

skilip commented

Not to be cocky (well maybe just a little) but what's the differnce then between weight and for example version, or php-version? Beside that, I can understand we need to avoid cluttering of the .info system. Any suggestions on how we could declare a module's weight on installation? Maybe something like hook_module_registry_alter? Or change hook_theme_registry_alter into hook_system_registry_alter ?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

@skilip: Will http://api.drupal.org/api/function/hook_system_info_alter work?

skilip’s picture

skilip commented

@webchick: I don't think so. If so, adding weight into the .info file should have the same effect.

[edit]Why isn't it possible to hook into the modules registry process while the theme registry does?[/edit]

moshe weitzman’s picture

moshe weitzman commented

Many many modules do this with an update query to the system table in hook_enable(). see devel or og for example.

skilip’s picture

skilip commented

Still odd IMO opinion, having a weight column in the system table, but no possibility in core to do anything with it.

skilip’s picture

skilip commented
Title: Add weight declaration in .info files » Put weight declaration of modules into a core funtion

No opinions about this? Am I completely alone here?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Postponed » Closed (duplicate)

This is a duplicate of #127641: Module weight in .info