Widget configuration form doesn't validate correctly the fields for width/height (also the full link configuration).
The empty() function doesn't differentiate 0 from '' or NULL so it is alway true saving always the default values and not 0 as needed in that case.

With this patch the ratio aspect always work, at least with Flickr, and also, the link configuration that maintains the desired option.

CommentFileSizeAuthor
#5 emimage_module.patch768 bytesjcmarco
#4 emimage_module.patch773 bytesjcmarco
emimage_widget_module.patch5.68 KBjcmarco

Comments

seaneffel’s picture

seaneffel commented
Status: Needs review » Reviewed & tested by the community

Just tested, seems to have solved the aspect ratio issue I was having. Now values of zero are being stored properly in the h & w fields. I'll mark this as rtbc.

aaron’s picture

aaron commented

ah, thanks for the patch. this is one of those issues that's come up before, and i thought it had been fixed. but sometimes we maintainers (read: me) overwrite each other's changes... :P

i plan to commit this tonight.

alex ua’s picture

alex ua commented
Status: Reviewed & tested by the community » Fixed

This worked and is being committed right now. Thanks!

jcmarco’s picture

jcmarco commented
Status: Fixed » Needs work
StatusFileSize
new emimage_module.patch773 bytes

In last commit, there is a line that was not fixed.

There is still a bug with thumbnail height

jcmarco’s picture

jcmarco commented
StatusFileSize
new emimage_module.patch768 bytes

Wrong patch before!

alex ua’s picture

alex ua commented
Status: Needs work » Fixed

Sorry about that. It's committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.