This is my first issue, so I hope I am putting this in the right place.

When I am in "Edit QT block", after I create several tabs and save, I find that it does not save in the same order that I saved it as. I have gone back in and rearranged the tabs in the order that I want them and save again, but it still does not stay in the order that I save them in.

More information:
Drupal version: 6.10
Number of tabs: about 50 (I don't know if there is a limit)
Ajax: No: All tabs will be loaded at page load.
Tab type: Node
Node: 1989 (example)
Teaser view: unchecked
Hide the title of this node: checked

If any other information is needed, please let me know.

Thank you.

Comments

katbailey’s picture

katbailey commented
Category: bug » support
Status: Active » Closed (works as designed)

Wow - this is definitely the first use case I've come across where so many tabs were required! What could you possibly need 50 tabs for? Anyway, there is no limit on the number of tabs but the values of the weight field, which is what they get ordered by, can only be between -10 and 10, which gives a total number of 21 different weights. So with 50 tabs you're obviously going to have tabs that share a weight with others, which would explain the ordering problem.

geide’s picture

geide commented

Katbailey, Thank you for your explaination. It makes complete sense, because I started having trouble right about the time I reached that 21 level.

I was actually using the "Mac style" which is more like a button. I have free ebooks by about 50 different authors and a tab for each author.

This brings up some other questions. If anyone has any other ideas, please let me know.

1. Is there a way of giving each tab a weight manually? I wanted the authors in alphabetical order. When I use weight in other instances, like blocks, if I give all the blocks the same weight, they will automatically put them in alphebetical order.

2. Is there a different module that would be better suited to this? I like the Quick Tabs because it was pretty easy. I'm still kind of new to Drupal.

3. Is there a way to create a set of buttons or tabs that open instantly in the same window, like Quick Tabs does?

What I am currently doing: www.practicalbible.com/ebooks. Book page with author (parent) and book (child). This works but Quick Tabs would be faster and easier for end-user.
What I was doing: www.practicalbible.com/top20 (the top part). It worked great, but was worried about the time it took to load and the ability to expand.
What I would like to do: www.practicalbible.com/top20 (the bottom part). This page is not currently being used on my site. I eventually will get rid of the top part and leave only instructions and the tabs.

If anyone has any ideas, I am more than open to them.

Thank you again katbailey. Your response was perfect.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Title: Tab order doesn't stay in the same order as saved » Tab order doesn't stay in the same order as saved (tab weight limit)
Category: support » feature
Status: Closed (works as designed) » Needs review

the weight field limit can be easily expanded..

admin.inc line 162

  $form['weight'] = array(
    '#type' => 'weight',
    '#default_value' => isset($details['weight']) ? $details['weight'] : $delta-100,
    '#delta' => 100,
  );
geide’s picture

geide commented

Pasqualle,

Thank you for responding.

I am fairly new to Drupal, so I may not be understanding what I am doing. I made the changes above in the code in admin.inc in the includes folder. I replaced the $delta-10 to $delta-100 and then added the '#delta' => 100, at the end but before the ); I made it look exactly like what you have above. It looks like it is expanding the range to be from -100 to 100 instead of -10 to 10.

Do I need to clear my cache or recreate the tabs that are out of order, or just start over? I tried rearranging again and then saving, but they go right back to where they were.

Thank you again.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

As I know it should be automatically corrected after the re-save, no special steps should be necessary..

If it does not work, then you may try to disable the javascript in your browser, so you can see the weight column with exact values, then you have a much finer control over the weight values. After save you should check the order again, and enable the javascript.

geide’s picture

geide commented

That worked perfect.

Steps taken:

1. Copied and replaced code above from Pasqualle to admin.inc line 162 in the includes folder in Quick Tabs module. (If you need line numbers to show, I use SciTE, it's free. Just copy and paste and then view line numbers.)

2. Disabled javascript by going to browser's Tools drop-down menu, click on Internet Options, click Security tab, click Custom level, scroll down to Scripting and disable Active scripting.

3. On website, go to Site building, Quicktabs. The category for Weights are now listed. Give each tab a weight and save. Note: You can create tabs here and Tab content, but you cannot give the node path. Save.

4. Go back and Enable Active scripting.

5. On website, go to Site building, Quicktabs. You can now give the node paths for the tabs you created earlier.

Thank you so much Pasqualle and katbailey. You both gave excellent advise and explained it in a way that even a newbie could understand.

Thank you again, geide

geide’s picture

geide commented
Status: Needs review » Fixed
pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Title: Tab order doesn't stay in the same order as saved (tab weight limit) » Tab weight limitation
Version: 6.x-2.0-rc3 » 6.x-2.x-dev
Status: Fixed » Needs review

I think we should fix this limitation..

katbailey’s picture

katbailey commented
Title: Tab weight limitation » Tab order doesn't stay in the same order as saved (tab weight limit)
Version: 6.x-2.x-dev » 6.x-2.0-rc3

Well, we wouldn't be removing the limitation, right? We'd just be increasing the limit. Anyway, I'm ok with this if you want to go ahead and commit.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Fixed

http://drupal.org/cvs?commit=190732

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.