Download & Extend
Issues

Contact mail greeting should be friendly and translatable

Posted by arnd on March 29, 2009 at 9:36am
Project:Drupal core
Version:7.x-dev
Component:contact.module
Category:bug report
Priority:normal
Assigned:Dave Reid
Status:closed (fixed)

Issue Summary

The salutation string is untranslatable and consists only of the user name. If the user name is the surname or the full name this is unacceptable, at least in german.

Please make it translatable like in the attached patch. Better would be a configurable solution, like for the site-wide contact form.

AttachmentSizeStatusTest resultOperations
contact.module.patch1.11 KBIdleFailed: Failed to apply patch.View details
Login or register to post comments

Comments

#1

Posted by Dave Reid on October 8, 2009 at 5:41pm
Version:6.10» 7.x-dev
Category:feature request» bug report

We should use some sort of approach like:
t('Hello @username,', array('@username => $account->name))

Also must be fixed in Drupal 7 (HEAD) first.

Also marked #514798: Be more polite in contact mail as a duplicate of this.

#2

Posted by Dave Reid on October 8, 2009 at 5:42pm
Title:salutation in email sent from personal contact form can be extremely impolite» Contact mail greeting should be friendly and translatable

#3

Posted by Dave Reid on October 8, 2009 at 5:59pm
Status:active» needs review

Patch attached for review.

AttachmentSizeStatusTest resultOperations
417244-contact-be-polite-D7.patch1.5 KBIdleFailed: Failed to apply patch.View details

#4

Posted by Dave Reid on October 8, 2009 at 6:14pm
Assigned to:Anonymous» Dave Reid

#5

Posted by Dave Reid on October 9, 2009 at 3:08am

Re-rolled for latest changes.

AttachmentSizeStatusTest resultOperations
417244-contact-be-polite-D7.patch1.29 KBIdleFailed: Failed to apply patch.View details

#6

Posted by andypost on October 11, 2009 at 5:50am
Status:needs review» reviewed & tested by the community

Reasonable and good for translation!

#7

Posted by System Message on October 12, 2009 at 3:45am
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#8

Posted by mattyoung on October 12, 2009 at 4:25am

.

#9

Posted by Dave Reid on January 21, 2010 at 6:47pm
Status:needs work» reviewed & tested by the community

Re-rolled only.

AttachmentSizeStatusTest resultOperations
417244-contact-be-polite-D7.patch1.33 KBIdlePassed on all environments.View details

#10

Posted by Dries on January 22, 2010 at 10:57pm
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#11

Posted by System Message on February 5, 2010 at 11:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here