Yep.

CommentFileSizeAuthor
#2 417542_comment_notify_no_node_setting_for_underprivileged_users_2.patch4.07 KBgreggles
#1 417542_comment_notify_no_node_setting_for_underprivileged_users.patch3.41 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: if user's don't have the abilit to post nodes don't confuse them about a node-notify default » if user's don't have the abilit to post nodes don't confuse them about a node-notify default and better db insert/update code
Status: Active » Needs review
StatusFileSize
new 417542_comment_notify_no_node_setting_for_underprivileged_users.patch3.41 KB

I'm somewhat concerned that the test for "permission to create nodes" might be too strict, but the only reasonable way to figure that out is to get feedback from people with non-standard nodes.

I also took this opportunity to use a slightly more efficient way of updating/storing the data.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: if user's don't have the abilit to post nodes don't confuse them about a node-notify default and better db insert/update code » if user's don't have the ability to post nodes don't confuse them about a node-notify default and better db insert/update code
Version: 7.x-1.x-dev » 5.x-2.x-dev
Status: Needs review » Patch (to be ported)
StatusFileSize
new 417542_comment_notify_no_node_setting_for_underprivileged_users_2.patch4.07 KB

Re-rolled the patch. And committed it. http://drupal.org/cvs?commit=277496

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Patch (to be ported) » Closed (fixed)

This module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.