if user's don't have the ability to post nodes don't confuse them about a node-notify default and better db insert/update code

greggles - March 29, 2009 - 18:36

Project:	Comment Notify
Version:	5.x-2.x-dev
Component:	Code
Category:	task
Priority:	normal
Assigned:	Unassigned
Status:	patch (to be ported)

#1

greggles - June 14, 2009 - 19:33

Title:	if user's don't have the abilit to post nodes don't confuse them about a node-notify default	» if user's don't have the abilit to post nodes don't confuse them about a node-notify default and better db insert/update code
Status:	active	» needs review

I'm somewhat concerned that the test for "permission to create nodes" might be too strict, but the only reasonable way to figure that out is to get feedback from people with non-standard nodes.

I also took this opportunity to use a slightly more efficient way of updating/storing the data.

Attachment	Size
417542_comment_notify_no_node_setting_for_underprivileged_users.patch	3.41 KB

#2

greggles - October 20, 2009 - 22:28

Title:	if user's don't have the abilit to post nodes don't confuse them about a node-notify default and better db insert/update code	» if user's don't have the ability to post nodes don't confuse them about a node-notify default and better db insert/update code
Version:	6.x-1.x-dev	» 5.x-2.x-dev
Status:	needs review	» patch (to be ported)

Re-rolled the patch. And committed it. http://drupal.org/cvs?commit=277496

Attachment	Size
417542_comment_notify_no_node_setting_for_underprivileged_users_2.patch	4.07 KB

if user's don't have the ability to post nodes don't confuse them about a node-notify default and better db insert/update code

Jump to:

#1

#2

User login

Contributor links