Using Garland there is a bullet point showing on the filters on admin/content/node. list-style-type was already set to none for the list, but we need list-style-image also set to none to deal with removing image bullet points.

Before and after screenshots and patch attached

CommentFileSizeAuthor
#4 node-filter_1.patch1.99 KBzoen
#2 node-filter.patch522 bytesjody lynn
Picture 1.png24.57 KBjody lynn
Picture 2.png25.31 KBjody lynn
node-filters.patch451 bytesjody lynn

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Title: Review extraneous bullet point on admin/content/node » Remove extraneous bullet point on admin/content/node
Status: Needs work » Needs review
StatusFileSize
new node-filter.patch522 bytes

This bullet point is still bugging me.

zoen’s picture

zoen commented
Title: Remove extraneous bullet point on admin/content/node » Remove extraneous bullet point on admin/content/content
Status: Needs review » Needs work

That bullet point bugs me too. It must be destroyed!!

This patch doesn't work with current HEAD. Its CSS fix depends on the offending bulleted list being inside div#node-admin-filter. But div#node-admin-filter is empty.

(Note: the content list has moved from admin/content/node to admin/content/content. I've updated that in the title of this issue.)

zoen’s picture

zoen commented
Status: Needs work » Needs review
StatusFileSize
new node-filter_1.patch1.99 KB

chx helped me track this weirdness down: function theme_node_filter_form() is useless. The filters are already themed by theme_node_filters(). So here's a new patch, which removes the function theme_node_filter_form() altogether in favor of theme_node_filters(). With this patch, div#node-admin-filter is wrapped around the filter form, so that your CSS fix applies successfully to the list of filters - and removes that evil, evil bullet point.

Please review! Be cruel!

Bojhan’s picture

Bojhan commented
Issue tags: +Usability

hah, yhea lets remove that.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Title: Remove extraneous bullet point on admin/content/content » remove useless theme_node_filter_form()

The bullet will be removed with #356240: bullets appearing on UL lists with list-style-type: none.
Your patch is removing a function (and not all occureneces of this nasty bullet).

Bojhan’s picture

Bojhan commented
Status: Needs review » Closed (duplicate)

Oke, lets fix it in the other issue then.