remove useless theme_node_filter_form()
Jody Lynn - March 29, 2009 - 23:12
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | node system |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | duplicate |
| Issue tags: | Usability |
Description
Using Garland there is a bullet point showing on the filters on admin/content/node. list-style-type was already set to none for the list, but we need list-style-image also set to none to deal with removing image bullet points.
Before and after screenshots and patch attached
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| node-filters.patch | 451 bytes | Idle | Failed: Failed to install HEAD. | View details | Re-test |
| Picture 2.png | 25.31 KB | Ignored | None | None |
| Picture 1.png | 24.57 KB | Ignored | None | None |
#1
The last submitted patch failed testing.
#2
This bullet point is still bugging me.
#3
That bullet point bugs me too. It must be destroyed!!
This patch doesn't work with current HEAD. Its CSS fix depends on the offending bulleted list being inside div#node-admin-filter. But div#node-admin-filter is empty.
(Note: the content list has moved from admin/content/node to admin/content/content. I've updated that in the title of this issue.)
#4
chx helped me track this weirdness down: function theme_node_filter_form() is useless. The filters are already themed by theme_node_filters(). So here's a new patch, which removes the function theme_node_filter_form() altogether in favor of theme_node_filters(). With this patch, div#node-admin-filter is wrapped around the filter form, so that your CSS fix applies successfully to the list of filters - and removes that evil, evil bullet point.
Please review! Be cruel!
#5
hah, yhea lets remove that.
#6
The bullet will be removed with #356240: bullets appearing on UL lists with list-style-type: none.
Your patch is removing a function (and not all occureneces of this nasty bullet).
#7
Oke, lets fix it in the other issue then.