Posted by idflorin on March 30, 2009 at 3:24pm
Jump to:
| Project: | BlogSpam |
| Version: | 6.x-1.4 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed |
Issue Summary
blogspam deletes comments, I think that spam comments should go to approval queue.
blogspam deleted all my old comments from my blog. why ?
Comments
#1
Moving comments:
The original aim was to lighten the load on the admin by blocking comments that failed. However - I can look into allowing an option "block comment/move comment to approval queue" as a feature request.
Deleting old comments:
This one's got me confused - I have no idea why it would even touch old comments.
It only activates on validation of comments (if you're interested from the api docs for hook_comments - validate "The user has just finished editing the comment and is trying to preview or submit it.").
Old comments should not even be seen by blogspam - unless they're edited. Not only that - it simply blocks the validate - such that the save fails - there is no delete call in the code at all.
I'll have to set up a test environment and test for this. It would help to know if you had any other comment modules installed (apart from the drupal standard ones) so that I can test interaction. Also - is there anything in the drupal logs about comment deletion?
#2
"Moving comments: "
this I think will better for everyone: move comment to approval queue, and delete after X days if not approved.
"Deleting old comments:"
all old comments where imported from a wordpress instalation, maybe this is the cause.
If you want I could provide you with the mysql db.
#3
Sorry for the wait - been away for a few days.
Moving vs. blocking
I do want to keep the ability to block comments at save time since one of the original wishes was "Keep obvious spam out of my approval queue - I'm fed up with deleting it". However - I am happy to make it an option and to make move to approval the default value.
I had a go at this - and I did get all the admin side done. However - I'm struggling with getting it to actually move to the approval queue - I need to debug this a bit more (a little short of time right now).
Deletion
I have not managed to duplicate this at all. I don't have a wordpress install to test with, but I simply haven't managed to do anything that has caused a deletion - and the code has nothing in it that calls delete (it simply returns an error to the save or preview form on validation - that's all it does).
If you would like to send the database I will be happy to take a look at it - you may well need to mail it since the upload here is max 1mb. You can mail it to my drupal.org address (chris+drupal.org@chrissearle.org). I don't suppose you have a copy from before the error too? If you do - then send it too (it would help to compare) - but don't worry about it if not. One thing I'd like to test is if there is a conflict with another module or similar.
Do you recall if the comments disappeared suddenly while you were actively posting/administrating the site or just were there one day and gone the next (wondering about what could have been the trigger - cron, some admin task, some posting task)? And - how were the comments imported from wordpress?
#4
I'm still totally unable to repeat the problem with comments being deleted. Nothing I've managed to do has caused any existing comments to be deleted.
I'm really starting to suspect either something odd with the database or some interaction/conflict with another module that is causing this.
Were you able to send the database ? I can't any mail - but perhaps it didn't make it through?
If its under 100Mb (or can be zipped to that or less) then you could also dump it on my drop.io - that's the hidden uploader (in other words - users that go to that link will not see other's uploads).
#5
magically every comment reappeared. I'm guessing a db problem from my site. I'm sorry for the late response. I uploaded the db also.
million apologies.
#6
Hi, has the "move to approval queue" functionality discussed here been committed to CVS?
#7
No - I never got it to work. It may be that when I get this working for d7 this may come - the hooks this module uses in d6 are removed in d7 so I'm not entirely sure.
#8
The dev version for drupal 7 does work the same way as the existing drupal 6 version - so the changes to the API didn't force this change. I'm not going to have time to make this change any time soon - I'll set this to postponed so that it doesn't get forgotten.
#9
Changed the title since the original poster's comments reappeared (suspected DB issue) and this is going to have to go onto the postponed queue - best that the title reflects the change wanted.