Patch to allow comments without subjects to display on admin comment list

Can't we write that shorter with less duplication?

There's also a problem with 'recent comments' block. Without a subject you can't click on the item.

is it not possible to set the subject regardless if the subject is disabled?

is it not possible to set the subject regardless if the subject is disabled?

I think it is... in fact comment_validate() seems to be doing it... Don't know why it's not working.

Anyway, I've changed the patch a bit: stolen some code from comment_validate() and reworded a bit. I'm not sure if the strip_tags(check_markup()) is done correctly, but test show it's all ok.

Another thing: it does not work too well, if the comment body is empty.

In theory body is required, but if you enter a couple of spaces, it's accepted. That's a bug in comment module.

Another problem: in admin/logs the subject is not listed. It says "Comment: added ." [it's translated so I don't know the exact english text]

And for setting comment subject on submission: yes, but that will work only for new comments. We would have to update all old comments without subjects.

another error because of this (comment subject unactivated):
if you change the comment viewing options to
"Threaded list - collapsed" or "Flat list - collapsed" there is no title too so you cant click and view them

In Drupal 4.6, the subject was set when the comment was submitted. On input, rather than on output. There shouldn't be empty comment subjects in your database.

I probably have them because I'm using HEAD ;)
I could update them with sql of course, if 4.6 is ok.

I spent a little bit time to investigate this.

the subject is created out of a few letters of the comment if he is empty.
you can see this working at the comment preview

but if you save it it wont be saved...
why?
therefore you have to look at comment_form_validate()

function comment_form_validate($form_id, $form_values) {
  comment_validate($form_values);
}

comment_validate() returns an array of all form values and it uses a reference & of $form_values
but what happens with the updated $form_values? they get lost.
I looked on drupaldocs.org for other _validate functions and I found just one which changes some values
and this one goes another approach which I used too:

function comment_form_validate($form_id, $form_values) {
  global $form_values;
  $form_values = array_merge($form_values, comment_validate($form_values));
}

I hope it is no problem that $form_values is one of the arguments and will be overwritten through the global $form_values

the rest of the patch is there that if the subject is disabled, that it does not get shown (a change for all themes)

AFAIK you can't change form values from _validate().

But clearly there is a need for such actions. So either we should allow _validate() to change content, or maybe we could add some new hook, e.g. _fix() that would be executed before _validate() and would fix some values?

sure thing it's called $form['#after_build']

but then this validation functions in HEAD are used the false way too:

• contact_mail_page_validate()
• user_pass_validate - who is using this? and why does it have no arguments?

cu tobi

Sounds like a bug report to me. Does this still happen?

Nope. I've had comments with no subjects showing up properly on delocalizedham.com for awhile now.