Hi,

I use URL aliases.
When I want to use "Page specific visibility settings" it only works with "system"-urls like "node/11" and not the alias "blog/titel-of-post"

Can I do something about it?

Thanks,

Jurgen

Comments

hass’s picture

hass commented
Status: Active » Fixed

I'm not able to repro.

You may have other modules installed that switch themes. There are potential conflicts... try to disable them all first and provide us a list of all your active modules if this does not fix your problem.

Jurgen8en’s picture

Jurgen8en commented

Yes, I also use Domain Access.

By accident, I found a solution. I need to use (added the last one)
blog
blog/*
*/blog/* (for my translations)

Now, together with Domain Access....
It worked on my main site, see http://www.igadgets.be/blog
On my second site, some page worked, some not.
http://www.icadeau.nl/blog NOT
http://www.icadeau.nl/nl/blog/online-op-1-september WORKS

I use:
blog
blog/*
blog/*/*
*/blog
*/blog/*
*/blog/*/*

hass’s picture

hass commented

Sorry, I've never used Domain Access module... you need to debug this for us.

Jurgen8en’s picture

Jurgen8en commented

Want I know for now is that Domain Access changes the global variable:
$custom_theme

I found this in theme.module:

  // Allow modules to override the present theme... only select custom theme
  // if it is available in the list of installed themes.
  $theme = $custom_theme && $themes[$custom_theme] ? $custom_theme : $theme;
Jurgen8en’s picture

Jurgen8en commented

I added something to domain_theme.module before the $custom_theme change

if(!$custom_theme){
hass’s picture

hass commented
Project: Sections » Domain
Version: 5.x-1.2 » 5.x-1.9
Category: support » bug
Status: Fixed » Active

Yes, this could be the reason! I cannot say what $themes[$custom_theme] is... I only know $custom_theme and $theme, but sections only set the $custom_theme var and if a module overrides this value because of a different modules order the last module wins. Domain Access loads after sections and therefore it may override the $custom_theme value of sections. Not sure if $themes[$custom_theme] is wrongly implemented.

I'm moving the issue to Domain Access. Please correct the version number if required.

hass’s picture

hass commented

Also make sure you have "Administration theme" set to system standard or section cannot work correctly...

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The discussion of this issue has nothing to do with the original request.

What action are you expecting from me here?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Title: Page specific visibility settings uses 'system'-urls » Custom theme conflict with Sections module

By the way, the correction in #5 is correct, otherwise DA will likely override the value set by other modules.

In the D6 version, this code already exists. So could you roll a patch and mark it a backport, please?

hass’s picture

hass commented

I was unable to repro what have been reported at the beginning... what he have written in #2 seems to depend on Domain Access module... (for e.g. "*/blog/*"), but I'm not able to repro this as I'm not using Domain Access module. Additional there might be a bug in Domain Access if theme switching doesn't work if the URL filter is correct...

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

@hass

Those are two entirely separate issues. The problem with Sections is that DA is overwriting your $custom_theme. This is correctable (there is even a UI for resetting the weight of Domain Theme), and #5 is perfectly correct.

The original issue _might_ refer to the process by which DA "steps aside" and does not enforce its access rules on pages like "user/UID/track".

Or it might be user confusion.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Postponed (maintainer needs more info)

Gee, thanks for following up on this, JurgenBen!

Jurgen8en’s picture

Jurgen8en commented

Hi,

I cannot following exactly anymore, there was some bug. But really don´t know way.
I did a very bad solution, added the code also to includes/theme.inc
Because the theme wasn´t set by the domain-module in some situations.

    // Assign the theme selected, based on the active domain.
    global $_domain;
if($_domain){
    $themed = domain_theme_lookup($_domain['domain_id']);
    // The above returns -1 on failure.
    if ($theme != -1) {
	    if(!$custom_theme){
		    $custom_theme = $themed['theme'];
	    }
    }
}
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

That code doesn't really make sense. It is the same as the code in domain_theme_menu(). Any idea under what conditions the theme was not set by domain_theme?

Jurgen8en’s picture

Jurgen8en commented

Hi,

I really don´t found any logic in it. Sometimes it was ok, sometimes not.
Now it is always ok, it does make sense :-)

Sorry, can´t help. Maybe that I did something wrong.
You may change the status of this post.

Jurgen

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Postponed (maintainer needs more info) » Patch (to be ported)

OK, I am going to chalk this up to a known issue in D5.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Patch (to be ported) » Closed (cannot reproduce)