According to http://drupal.org/node/383600#comment-1392166 we should move all test files accept node.test into a subdirectory tests/

For node, these are:

node_test.module
node_test.info

This is a novice task.

CommentFileSizeAuthor
#1 jamesan_418760.patch2.72 KBJamesAn

Comments

JamesAn’s picture

JamesAn commented
Status: Active » Needs review
StatusFileSize
new jamesan_418760.patch2.72 KB

Voila. Teh fun..

Status: Needs review » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn commented

But it works! I applied it on my local D7 instance and the tests pass. -.-"

The modules/node/node_test.info is now located in modules/node/tests/node_test.info, which was the whole point. #408982: Skip syntax check if file doesn't exist points out the bug in PIFR, where patches that delete files throw a "Failed: Invalid PHP syntax" error as PIFR attempts to execute the deleted file anyway.

JamesAn’s picture

JamesAn commented
Status: Needs work » Needs review

Hmm.. does setting the status back to needs review schedule a retest? Only one way to find out!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good and 10687 passes is the current magic number so all the tests ran.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.