as far as I know, it's legal to remove the credit link at the bottom of the theme, and instructions for hacking the theme to do so are included on the handbook page (http://drupal.org/node/357261#credit-links).

This doesn't seem like the best solution. I posted a comment (http://drupal.org/node/357261#comment-1419032) to that page describing how to subtheme marina to get rid of the credit link cleanly. However, it might be nice to make this an admin option in the theme itself. Or maybe it shouldn't be that easy to remove.

Alternatively, setting the credit link as a variable in the theme's code would make it a lot easier to remove in the subtheme. I had to copy/paste the text of the link, so if that ever changed, my subtheme override would fail. If it were available as a variable/constant, I could be sure I'm removing the right text every time, even after upgrading.

I am willing to post the entirety of my subtheme somewhere if that helps anyone. It exists just to remove the credit links and does absolutely nothing else :)

Comments

jwolf’s picture

jwolf commented
Status: Active » Closed (fixed)

http://drupal.org/node/357261#credit-links

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Closed (fixed) » Active

@jwolf: yes that node describes a fairly bad way to remove credit links, and I also posted an improved method in the comments there.

My point with this issue was that even using a subtheme to remove the credits, I'm relying on the string not changing at all. So storing the credit as a variable in Marina would make it a lot easier to remove reliably.

It's possible that it was intended to be (somewhat) difficult to remove the credit links, since the theme does after all represent a lot of work. If that's the case, I can see closing the issue. But if not, there should be a better solution than a) hack theme, b) subtheme, c) use display: none to hide credits. Maybe a configuration option for the theme?

I'm willing to provide a patch if there's interest.

jwolf’s picture

jwolf commented
Status: Active » Closed (fixed)

@kscheirer - Please feel free to post your solution to our TNT group at http://groups.drupal.org/topnotchthemes

Additionally, since you were kind enough to post your solution as a comment to the Acquia Marina Handbook - http://drupal.org/node/357261#comment-1419032 - I don't see a need to keep this issue open.