Download & Extend

jQuery.each causes scripts to bomb if there are no settings

Project:jCarousel
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I'm using jCarousel with callback functions, whose names cannot be passed through drupal_to_js. When I just call jq_add('jcarousel') or jcarousel_add(), the browser javascript bombs with an error and all other scripts on the page never run. This is because you're attempting to run jQuery.each() on a non-existent array.

Here's a patch that gets me through this spot.

AttachmentSize
jcarousel-without-settings.patch892 bytes

Comments

#1

How about this?

AttachmentSize
jcarouselwheee.patch 967 bytes

#2

Version:6.x-1.1» 6.x-1.x-dev

#3

Status:needs review» fixed

http://drupal.org/cvs?commit=284670

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.