jQuery.each causes scripts to bomb if there are no settings

bangpound - March 31, 2009 - 01:06
Project:jCarousel
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I'm using jCarousel with callback functions, whose names cannot be passed through drupal_to_js. When I just call jq_add('jcarousel') or jcarousel_add(), the browser javascript bombs with an error and all other scripts on the page never run. This is because you're attempting to run jQuery.each() on a non-existent array.

Here's a patch that gets me through this spot.

AttachmentSize
jcarousel-without-settings.patch892 bytes

#1

Rob Loach - April 7, 2009 - 20:36

How about this?

AttachmentSize
jcarouselwheee.patch 967 bytes

#2

Rob Loach - April 7, 2009 - 20:36
Version:6.x-1.1» 6.x-1.x-dev

#3

Rob Loach - November 5, 2009 - 23:12
Status:needs review» fixed

http://drupal.org/cvs?commit=284670

#4

System Message - November 19, 2009 - 23:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.