Download & Extend
FileField » Issues

filefield_widget_file_path is hardcoded to global $user

Posted by deviantintegral on March 31, 2009 at 4:11pm
Project:FileField
Version:6.x-3.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I'm trying to generate the path for a file based on a user which isn't currently logged in. filefield_widget_file_path() uses the currently logged in user; is there any reason why $user can't be a function parameter? If not, let me know and I'll work on a patch.

Thanks!

Login or register to post comments

Comments

#1

Posted by quicksketch on March 31, 2009 at 6:35pm
Category:bug report» feature request

I'd be happy to change this to using an $account parameter.

<?php
function filefield_widget_file_path($field_instance, $account = NULL) {
  $account = isset($account) ? $account : $GLOBALS['user'];
?>

Patchin' finger is ready. ;-)

#2

Posted by deviantintegral on April 8, 2009 at 6:46pm
Status:active» needs review

Here it is! I've also corrected the phpdoc for the first parameter.

AttachmentSize
419616_account_parameter.patch 1.07 KB

#3

Posted by quicksketch on April 8, 2009 at 7:26pm
Status:needs review» fixed

Thanks, committed!

#4

Posted by frankcarey on April 21, 2009 at 4:45am

Nice, I just realized i needed this, thanks guys :)

#5

Posted by frankcarey on April 21, 2009 at 5:06am

I noticed that field_file_save_file() suffers from the same issue?
#439952: Global user used to set the $file->uid]

#6

Posted by System Message on May 5, 2009 at 5:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.