Unnecessary code in ffmpeg helper's hook_nodeapi [#420036]

Hello,

There is an unneeded function call in video_ffmpeg_helper.module:473 to _video_ffmpeg_helper_get_video_info(). This call is in the hook_nodeapi() implementation of the module.

It's unneeded because the function returns value, and doesn't set anything by reference on &$node, yet whatever it returns is not being captured.

Thank you..

Comments

Comment #1

AmrMostafa commented 31 March 2009 at 23:42

Correction, it's on line 260. Here is the snippet:

if(variable_get('video_ffmpeg_helper_auto_resolution', false) || variable_get('video_ffmpeg_helper_auto_playtime', false)) {
  _video_ffmpeg_helper_get_video_info($node);
}