Posted by joshuajabbour on April 1, 2009 at 1:19am
6 followers
| Project: | Comment CCK |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | joshuajabbour |
| Status: | closed (fixed) |
Issue Summary
I'm working on a updated patch for comment_cck -- combining a few other patches from the issue queue, and cleaning up a bunch of unnecessary code.
Comments
#1
OK, here's the patch. This patch supersedes the following, and fixes the issues contained within:
#309367: Not Compatible with CCK 6.x-2.1
#295478: Double appearance of checkbox "Allow comments to alter this field"
#369610: fieldgroup not followed
It also cleans up the module itself, removing some unnecessary code, and just generally bringing it up-to-date. You'll need a current version of CCK, as one of the issues this patch fixes is an incompatibility with an older version of CCK (though I'm not sure exactly when the function names changed).
This can be applied to the dev version of comment_cck, and should be used instead of the patches in the issues listed above. The patch includes an update function to clean up some old variables.
Please test this so hopefully an updated version can be released.
#2
This patch doesn't work with imagefield or filefield fields (same as #241687: Integration with filefield and imagefield -- I don't think it worked before this patch either).
I do have a fix, so new patch coming soon...
#3
I think, it doesn't matter, just apply this patch, and write another one for the imagefield etc. Any chance there could be an install readme too. When I installed this, and it didn't work due to cck changing etc. I had no idea where to enable it or configure it.
Thanks
#4
Keep it up guys!
Subscribing.
Thanks!
#5
Yes, I'll create an install readme.
Also, I'm trying to create larger meta-patches, because a bunch of smaller patches would have to be applied in a specific order, which is frustrating for new users. If the patches were being applied to CVS in a reasonable timeframe, I'd totally go that route. But since they aren't, I'm trying to make it easier for users to get a functional version of this module with the least amount of work. (Plus, the changes between the CVS version and my updates are drastic -- and even more so when I rewrite it to support all fields.)
The patch above still applies and is fully functional except for Image and File fields... so feel free to use it. I expect to have a new patch ready by the weekend (I was out of town for a while, so this dropped off the radar).
#6
subscribing
BTW: why don't you ask for co-maintenance?
#7
@joshuajabbour: Thank you for posting your work and not letting this module go by the way side. :)
#8
Committed. Thanks!
#9
Automatically closed -- issue fixed for 2 weeks with no activity.