Download & Extend
Secure Pages » Issues

Front page toggles between HTTP and HTTPS

Posted by mkalkbrenner on April 1, 2009 at 3:27pm
Project:Secure Pages
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:grendzy
Status:fixed

Issue Summary

If pages section at admin/build/securepages contains an empty line (what usually happens if someone hits ENTER after the last record) the front page toggles between HTTP and HTTPS each time you reload. The reason for this is that the empty line gets transformed into an empty or condition for the regular expression that matches urls and the empty or condition matches the front page.

I attached a simple patch that eliminates empty lines at the end of the list of pages when validating the admin form.

AttachmentSize
securepages.admin_.inc_.prevent-front-page-toggle.patch502 bytes
Login or register to post comments

Comments

#1

Posted by sanduhrs on May 30, 2009 at 11:01am

See #286333: Blank line in securepages_secure textarea causes Homepage redirection for additional information.

Patch seems reasonable, didn't test it yet.

#2

Posted by gordon on July 2, 2009 at 7:40am
Status:needs review» needs work

This looks ok, but you need to add an update which will do fix up the current variables when the update.php is run.

#3

Posted by adamo on September 21, 2009 at 8:49pm

Thanks for figuring this out! :)

#4

Posted by chaloalvarezj on November 10, 2009 at 4:36am

Thank you! you saved my day

#5

Posted by Nathan.Ray on November 24, 2009 at 10:39am

Legend! Thanks a bunch!

#6

Posted by criznach on December 8, 2009 at 12:03am

I believe this was causing a redirect loop in firefox on one of my sites. I removed the trailing newline and it started working immediately.

#7

Posted by jleinenbach on December 13, 2009 at 12:41am

Patch works. But remove the trailing newline before applying this patch.

#8

Posted by LiveWire on May 29, 2010 at 3:27pm

MUCHOS GRACIAS! Thank you a ton.

#9

Posted by budda on March 15, 2011 at 2:32pm

can you not just re-save the settings form to have your values trimmed?
obviously the redirection would need to be disabled on the settings form in order to get in to the site :-)

#10

Posted by heikwan on March 22, 2011 at 8:59pm

My front page still alternates between http and https even after the patch.

#11

Posted by mkalkbrenner on March 23, 2011 at 8:26am

Did you save your settings again after the patch?

#12

Posted by adr_p on May 26, 2011 at 12:15pm
Status:needs work» needs review

Please see http://drupal.org/node/587000#comment-4519010.

#13

Posted by grendzy on August 23, 2011 at 5:08pm
Assigned to:mkalkbrenner» grendzy

It seems the front page matching is broken anyway. Here's a new patch:

AttachmentSize
420712.patch 814 bytes

#14

Posted by Bob Morse on August 24, 2011 at 1:47pm

I applied this patch on version 6.x-1.9 and it seems to have worked fine. Thanks so much!

#15

Posted by grendzy on December 13, 2011 at 1:19am

I believe this is fixed in the 6.x-2.x branch. Please test and report back if you can.

#16

Posted by grendzy on February 3, 2012 at 2:54am
Status:needs review» fixed

There have been no further reports of this problem in the 6.x-2.x branch, and we have tests now too.

nobody click here