Offshoot from #345984: Client-side caching of administration menu:

Ensure the hash properly changes when the menu is rebuilt.

I am absolutely not happy with the current implementation, and after tinkering intensively about it, we should really rebuild whenever hook_menu() is called.

AFAIK, menu_rebuild() is (almost?) always called at the end of system-altering requests, so we basically just need to ensure the _next_ request uses a new hash (i.e. truncate the cache table).

Comments

sun’s picture

Status: Active » Needs review
StatusFileSize
new1.91 KB

This is how I solved it in 5.x-3.x. (already committed)

sun’s picture

Status: Needs review » Needs work
StatusFileSize
new2.64 KB

Sorry, this one it is.

sun’s picture

Version: 6.x-3.x-dev » 5.x-3.x-dev
Status: Needs work » Fixed

A similar fix has been committed to 6.x-3.x+ via #276751: Allow to alter/customize/add links in administration menu.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.