| Project: | Import/Export |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Heya, this is a big refactoring of the module. I managed to clean up a lot of things, making them more concise, saving lines of code, using more Drupal APIs etc.
One change that needs to be discussed is I changed the default location for saving exported files to be a sub directory of the files dir. I'd like to know if your requirements need them to be saved to the tmp directory? If not than the files directory seems to be a good solution. Easier for most people to get to. It's configurable (the admin can enter a path), but we could go even further and give the admin the options of a) the tmp directory, b) the files diretory, or c) enter a path of their choice. Let me know how you'd like it.
This patch addresses several of the other issues in the queue as well.
I also attached a tgz'd version of the module for you to look at to save you the trouble of patching if you like.
| Attachment | Size |
|---|---|
| importexport.patch | 21.15 KB |
| importexport.tgz | 2.38 KB |
Comments
#1
Working off of Robert's code, here is some further development:
It's a little light in the documentation department and could use some love from hook_help and advanced help!
Attached are patches which apply to 6.x-1.x-dev release, or check out the attached archive file for the whole module.
#2
Reviewed #1, and I like it.
The only problem that I have with it is that I had to remove the lines about vocabularies, because I don't use taxonomy. Other than that, it works as expected.
Thanks!
#3
Dear module maintainer - have you had a chance to look at the code in http://drupal.org/node/421010#comment-1508162 ?
#4
Re #2: would be better to check for whether the taxonomy module is enabled.