The problem arises on pages that have multiple forms with the same submit button text. There is currently no way to specified which form you want to submit. We need an extra parameter or something that allows the form_id or something unique to be passed in order to specify which form to submit.

I thought there was a previous issue for this, but I can't seem to find it. Since #335035: drupalPost() incorrectly submits input for disabled elements will condense the drupalPost() parameters I would like for it to get in before we patch this.

CommentFileSizeAuthor
#7 simpletest_drupalPost_form_id.patch9.36 KBstella
#3 simpletest_drupalPost_form_id.patch3.92 KBstella

Comments

sirkitree’s picture

sirkitree commented

I've run into this while trying to assign an action to a trigger where there are multiple forms all with the same select option and button name. I ended up doing a direct INSERT instead but would rather be able to use drupalPost().

Scott Reynolds’s picture

Scott Reynolds commented

subscribe +1

http://3281d.com/2009/03/27/death-to-subscribe-comments

stella’s picture

stella commented
Status: Active » Needs review
StatusFileSize
new simpletest_drupalPost_form_id.patch3.92 KB
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I ran into this today. Will try to test/review later.

Scott Reynolds’s picture

Scott Reynolds commented
Status: Needs review » Needs work

Whats missing from this patch is the test to make sure it works :-D

boombatower’s picture

boombatower commented

There was a different issue (can't remember) that added parameters to drupalPost and it merged them into a single options array which was way cleaner...perhaps if someone can find the issue we could get that in or implement in this issue.

Not a stopper to this patch of course, just a suggestion.

stella’s picture

stella commented
Status: Needs work » Needs review
StatusFileSize
new simpletest_drupalPost_form_id.patch9.36 KB
c960657’s picture

c960657 commented

drupalPost() already has a lot of arguments. I wonder whether it would be better to supply the form_id as part of the $edit array?

I.e. like this:

+    $edit = array('form_id' => 'simpletest_test_multiple_form_0', 'test_field' => 4);
+    $this->drupalPost('simpletest-test/form-post', $edit, t('Submit'));

instead of like this:

+    $edit = array('test_field' => 4);
+    $this->drupalPost('simpletest-test/form-post', $edit, t('Submit'), 'simpletest-test-multiple-form-0');

form_id already occurs as a hidden field, so there is no risk of colliding with an existing field name.

boombatower’s picture

boombatower commented

#335035: drupalPost() incorrectly submits input for disabled elements is the route I think is best in regards to arguments.

Status: Needs review » Needs work

The last submitted patch failed testing.

EvanDonovan’s picture

EvanDonovan commented

#360023: Update node_comment_statistics during "Publish comment" action has been postponed on this - a change which I think is very important to make core Drupal have a complete set of actions for content moderation. Can this still be considered for D7, or #335035: drupalPost() incorrectly submits input for disabled elements if that supersedes this issue? It would be a shame, imo, if D7 shipped without an action to publish comments, since it has an action to unpublish them.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I use different approach for the same task #601398: Simpletest does not allow assigning actions to triggers
But it needs little help with comment

effulgentsia’s picture

effulgentsia commented
Status: Needs work » Fixed

Fixed with #601398-60: Simpletest does not allow assigning actions to triggers and that issue has more follow-up.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I need to mention that follow up changes $form_id to $form_html_id - a actual HTML ID of form

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.