In the theming function of delicious.module, there is a minor error on line 948. Currently, the line reads as:

<?php
      $output = "<div class='delicious-user'><ul class=delicious_menuList id=delicious_menu_0>\n$output</ul>\n</span>";
?>

It should be changed to (with other minor changes made for source readability):

      $output = "<div class=\"delicious-user\">\n<ul class=\"delicious_menuList\" id=\"delicious_menu_0\">\n$output</ul>\n</div>";

I found this error when trying to determine why the right-hand menu for the theme I'm using (friendselectric) was shifting down. I looked, and there is no span started by the code, but there is a div started that doesn't get closed.

Comments

merlinofchaos’s picture

merlinofchaos commented

Odd that I did that.

Good catch. Note that it is against the Drupal style-guide to use \" unless it is necessary, which is why I use ' inside those, since it's perfectly valid HTML to use single quotes.

I'll fix this soon.

Sean Et Cetera’s picture

Sean Et Cetera commented

I was not aware of that. Noted.

As the case is, there were instances of when the code didn't have any quotes (single or double). I believe the code that ended in a span is an example of this.

Just trying to be helpful.

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Fixed

Fixed, checked in.

dries’s picture

dries commented
Status: Fixed » Closed (fixed)