Download & Extend
Terms of Use » Issues

Double encoding on @link

Posted by Moonshine on April 2, 2009 at 5:03am
Project:Terms of Use
Version:6.x-1.10
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Howdy...

Just a heads up that l() actually does a check_plain() on its own for link text. So when the title is encoded before sending it in you end up with some funky encoding for things like "Terms & Conditions" where the ampersand is double encoded.

Thanks!

Login or register to post comments

Comments

#1

Posted by Chill35 on April 4, 2009 at 4:50pm

Thanks Moonshine! I will fix this.

:)

#2

Posted by roychri on May 28, 2009 at 5:17pm
Status:active» needs review

Here's the patch for 1.10

AttachmentSize
421346.patch 620 bytes

#3

Posted by DeFr on December 16, 2009 at 6:21pm
Status:needs review» reviewed & tested by the community

Very simple patch, works as advertised and badly needed in case you have something that check_plain converts to an entity in the link label, otherwise the double escaping makes the entity visible (such as ' which is in the default fr.po) .

Thanks @roychri

#4

Posted by Kars-T on April 12, 2010 at 2:52pm
Status:reviewed & tested by the community» fixed

#421346 by roychri | Chill35: Fixed Double encoding on @link.

#5

Posted by System Message on April 26, 2010 at 3:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.