Clickatell areacode bug

An updated Clickatell module is currently under review. In this module I have removed the line that appends the country code to the phone number, and left the country-code select field only for reference.

You can get the updated module from here (http://drupal.org/node/441650) but please be aware that the module has not yet been approved by the group.

I'll assign this ticket to myself for now, and will close once the updated Clickatell module has been approved.

Tagging.

Can't a check just be done on the number the user has entered and if the number is not already prefixed by the areacode, then append it.

Here is the patch I've made for this, it takes care of leading zeros and not duplicating the country code. It will fail if someone enters a number that doesn't start with a 0 that starts with the same numbers as the country code.

--- sms_clickatell.module.orig  2009-07-09 15:58:59.000000000 +0200
+++ sms_clickatell.module       2009-11-10 09:43:34.000000000 +0200
@@ -91,7 +99,9 @@
  * Callback for sending messages.
  */
 function sms_clickatell_send($number, $message, $options) {
-  $number = $options['country'] . $number;
+  if (!preg_match('/^'.$options['country'].'.*/',$number)) {
+    $number = $options['country'] . ltrim($number,0);
+  }
   return sms_clickatell_command('sendmsg', array('number' => $number, 'message' => $message));
 }