Change XML Feed icon to new standard

Here's and updated patch, fixes a typo and an extra XML reference.

Here is the smaller 12x12 icon, I think this one might be more appropriate.

By the way this patch and this icon, makes feed pages look *a lot* better, just that simple icon. It fits really well. Let's get this in :-)

Just announced, the Outlook 12 team has announced they'll be using the same icon for feeds: http://blogs.msdn.com/michael_affronti/archive/2005/12/15/504316.aspx

Let's get Drupal up to the standard too, first CMS to carry it, certainly able to get a lot of buzz about that.

new icon ++

depennding the color theme, one can also use an onther color for the new icon, note that i think that it should be orange but if you want another, at http://feedicons.com/ are some.

-1. This patch changes the OPML icon to the new feed icon, and that's wrong. OPML is an entirely different format, nor has it been indicated, anywhere by either Mozilla or Microsoft, that OPML lists will fall under the icon they've agreed upon.

Morbus, the XML icon is also not much descriptive for OPML IMHO. Quite some sites providing OPML I have seen use the official OPML script writing icon. See eg. http://www.abvakabofnv.nl/feeds/

+1 on the new orange icon for the RSS feeds. OPML needs discussion.

Well the OPML icon has been wrong in core for quite sometime as well and it doesn't appear there is a particular icon to use. I see no reason for *not* using this icon for now until a more standard or convetional icon arises. Thoughts?

m3avrck: it hasn't been "wrong" because there's been no "right". The XML icon has little indication on whether the resultant data is RSS, Atom, or OPML. That's because no one has ever said, either way, whether it should or it shouldn't. However, Mozilla, through its toolbar icon, and now Microsoft, through it's desire to use that icon, have said strictly that the icon is to be used for feeds (or either RSS or Atom). They have offered no indication that it should be used with OPML (or any of the other three standards that are out there for feed subscriptions). Let's not be the first to *incorrectly assume* that this new "feed" icon is also good enough for "feed subscription lists", otherwise we'll dillute the new icon until it has about as much strength as the current orange XML ("Is this an RSS feed? An Atom feed? An OPML list? An OML list? A microformat?").

Goba: the use of the OPML icon, as per that website, is not well-recognized. OPML is a generic outliner format - it's use as a feed subscription list came later in its lifetime. Using the OPM" icon is about as useless as the XML icon - yes, it's OPML, yes, it's XML, but what kind of OPML, what kind of XML is it? That's primarily why the orange XML icon was used for it - since the icon was "recognized" (visually, not meaningfully) as being related to RSS.

Morbus good point, I wasn't trying to use it incorrectly and I agree with what you are saying, I just didn't explain to well :-P

As for the OPML icon, I see two things, keep it as the XML icon as Morbus suggests, or we can use the icon that Goba points us to, which is used here as well: http://www.opml.org/ ... as you can see, there is no widely adopted icon yet and perhaps the XML icon is still sufficient.

Ok here's a new patch which leaves the OPML feeds with the XML icon in core but updates all of the other feeds with this new icon.

And here's the feed icon resized to 14x14 so it is the same height as the XML icon.

I think this solves both of the issues, right?

+1 for drupal_30.patch.

+1 in general

and now my 0.02 ct:
why not let it be called theme_xml_icon()
and then introduce a second argument
which indicates the icontype
eg. rss, feed or opml (default-value remains xml)

@ Tobias: Why limit it to XML? There are lots of icons in Drupal. Why not theme_icon($type), where "type" is "feed" (XML or RSS or the radio or whatever), "warning" (used by the log display), "newforum" (or something), or any of the other icons floating about Drupal. That way, a given theme can easily retheme the graphics as well as the layout of the page.

yes, I thought about this too but we had a disussion about this as we discussed the tango-icons.

I would like such a theme_icon()
which should be a function which handles the most graphical links (like rss, opml, somone can do a nicer admin interface, menuicons etc)
It should use the tango-naming-convention
and should look on different places for a specific logo
first go throuh a logo-hook (so we can change the icon on every place)
then look for that icon in the themes' icon dir
if it is not there goto the /misc/icons-dir
and if it is not there too go to the module's directory
and if we cant find a nice Icon then show a special "no-icon-found"-icon

Guys, if you would like to see this change in 4.7, do not start to invent new theme functions, or anything else. IMHO it is too late now. If you are about to target the next release, then it is fine, but dreaming about new functionality this late in the release process does not help adopting the new feed icon.

Right, I agree with Goba, these new theme functions make sense, however these are for the next release, not 4.7 which is due out soon. This patch introduced is just a minor icon change which can still make it in. These other theme functions need some thought and a proposed patch etc so that should be a seperate issue.

If everyone likes the patch in #12 and icon in #13, can someone set this to commit?

reviewed this patch but had no time to patch my local head-copy...

it is not a very big change but helps to bring more consistency into the world

FWIW, I've been seeing this icon turn up on *lots* of sites I frequent, it is definetly being adopted at a fast rate. Be great to see all 4.7 sites using this icon as well to further help out those lost RSS users (which appears to be a significant portion of the population right now).

Looks like everyone is pro this change. I expected at least a bunch of people to be against it. :-)

Rock! The Drupal community is starting to unify it's voice :-)

So what's the status, this going in? :-p

I prefer the larger feed.png (16x16)... if we make the icon height the same as XML before (so 14x14), then the actual area of the icon is less than half of what it was before.

Having both a theme_xml_icon() and theme_feed_icon() is kind of icky, but it's not simple to create a theme_icon() quickly (which is not the same as theme_image(), because it's about providing a functional UI widget rather than just an image). For 4.8 it's possible we'll more towards more icon usage in admin, so it's reasonable to postpone it.

For the moment, the current patch is good and it makes Drupal look more contemporary. Committed to HEAD.