convert common.inc to use new static caching API

Per discussion w/ catch - if you have a variable name more complex than just __FUNCTION__, use a ':' to separate the suffix (this will avoid colliding with any other valid function name). e.g. :

&drupal_static(__FUNCTION__ . ':second_var');

I would not make this change:

 function drupal_random_bytes($count)  {
-  static $random_state;
+  $random_state = &drupal_static(__FUNCTION__);

that static should never be reset.

Also, check w/ chx or boombatower about this one:

@@ -788,7 +788,7 @@ function _drupal_log_error($error, $fata
   // When running inside the testing framework, we relay the errors
   // to the tested site by the way of HTTP headers.
   if (preg_match("/^simpletest\d+/", $_SERVER['HTTP_USER_AGENT']) && !headers_sent() && (!defined('SIMPLETEST_COLLECT_ERRORS') || SIMPLETEST_COLLECT_ERRORS)) {
-    static $number = 0;
+    $number = &drupal_static(__FUNCTION__, 0);

Likely you have to fix the test so it resets the js using the new method.

See #7 - that function should not be converted.

Looks fine - looking at _drupal_log_error() I'm still not sure we want or need to convert that - but I'm not sure it makes much difference.

Can you add a brief code comment to the ones that are not converted?

if the second param is always passed to drupal_load_stylesheet() then byassing it makes sense (and maybe it should jsut be a required param) - otherwise maybe it should be converted.

patch fails to apply: Hunk #4 FAILED at 164.

function drupal_set_header() seems to have moved to bootstrap.inc

re-roll just omitting that hunk, since the function in bootstrap.inc seems to be already converted.

seems to be a problem in the code here:

 function drupal_load_stylesheet($file, $optimize = NULL) {
-  static $_optimize;
+  // $_optimize does not use drupal_static as it is set by $optimize.
+  $_optimize = &drupal_static(__FUNCTION__);